Change in coreboot[master]: mb/faceboot/fbg1701/romstage.c: Set disable_saved_data - coreboot-gerrit

6 Apr 2021


      Attention is currently required from: Frans Hendriks, Wim Vervoorn.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52128 )
Change subject: mb/faceboot/fbg1701/romstage.c: Set disable_saved_data
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52128/comment/adc5f6a6_7055b8e1 
PS2, Line 9: ASSERTION ERROR
...
ASSERTION ERROR: file 'src/security/vboot/common.c', line 23
Do you expect this in commit message?
Yes.
Patchset:
PS4: 
The proper fix would be to have the VBOOT related part of the MRC cache driver depend on !VBOOT_START_IN_ROMSTAGE.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52128
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfedfa82e746626f35e6f1d426a4de768c594b93
Gerrit-Change-Number: 52128
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Frans Hendriks fhendriks@eltan.com
Gerrit-Attention: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Comment-Date: Tue, 06 Apr 2021 14:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment