Attention is currently required from: Julius Werner.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86115?usp=email )
Change subject: symbols: Add REGION() and REGION_END() macros ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hmm... does it? I think it would just make them follow the macro definition to the source but that doesn't really help either.
On seeing `_sram`, inexperienced people would try to search for that word in the code base and found nothing. On seeing `REGION(sram)` and the definition of those macros, IMO it would be easier to figure out what to grep.
For symbols prefixed with underscores I think there at least exists a lot of precedent among various C code bases to represent linker script symbols that way.
Okay, I didn't know that. If that's the case and you don't think this patch improves anything, I'm going to abandon this.
-
Yu-Ping Wu (Code Review)