Change in coreboot[master]: util/abuild: Use absolute paths for (failed|passed)_boards - coreboot-gerrit

5 Nov 2018


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/29451 )
Change subject: util/abuild: Use absolute paths for (failed|passed)_boards
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/29451/2/util/abuild/abuild
File util/abuild/abuild:
https://review.coreboot.org/#/c/29451/2/util/abuild/abuild@103
PS2, Line 103: sed 's,^/+,/,
if $dir is //foo/bar, that would remove one /. Problem is, // prefix is defined by POSIX as implementation defined. probably doesn't matter much in practice though (although, that Linux implementation in Windows maybe?)
-- 
To view, visit https://review.coreboot.org/29451
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief00e28e09a4714b0106c35ad4f4e9c696f6aad4
Gerrit-Change-Number: 29451
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Nov 2018 22:50:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No