HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61630 )
Change subject: drivers/intel/fsp1_1: Drop duplicated "ERROR" in log messages ......................................................................
drivers/intel/fsp1_1: Drop duplicated "ERROR" in log messages
Change-Id: I25f56a6f3ca1814666929e91400f52b75a5d607d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/ramstage.c 2 files changed, 5 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/61630/1
diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c index c74955e..78700a9 100644 --- a/src/drivers/intel/fsp1_1/raminit.c +++ b/src/drivers/intel/fsp1_1/raminit.c @@ -193,8 +193,7 @@
/* Verify all the HOBs are present */ if (fsp_verification_failure) - printk(BIOS_ERR, - "ERROR - Missing one or more required FSP HOBs!\n"); + printk(BIOS_ERR, "Missing one or more required FSP HOBs!\n");
/* Display the HOBs */ if (CONFIG(DISPLAY_HOBS)) @@ -209,8 +208,7 @@ if ((fsp_memory != NULL) && (cbmem_root != NULL) && (cbmem_root->PhysicalStart <= fsp_memory->PhysicalStart)) { fsp_verification_failure = 1; - printk(BIOS_ERR, - "ERROR - FSP reserved memory above CBMEM root!\n"); + printk(BIOS_ERR, "FSP reserved memory above CBMEM root!\n"); }
/* Verify that the FSP memory was properly reserved */ @@ -218,7 +216,7 @@ (fsp_memory->PhysicalStart != (unsigned int)fsp_reserved_memory_area))) { fsp_verification_failure = 1; - printk(BIOS_ERR, "ERROR - Reserving FSP memory area!\n"); + printk(BIOS_ERR, "Reserving FSP memory area!\n");
if (CONFIG(HAVE_SMI_HANDLER) && cbmem_root != NULL) { size_t delta_bytes = smm_base diff --git a/src/drivers/intel/fsp1_1/ramstage.c b/src/drivers/intel/fsp1_1/ramstage.c index dcb32c7..d85ba7c 100644 --- a/src/drivers/intel/fsp1_1/ramstage.c +++ b/src/drivers/intel/fsp1_1/ramstage.c @@ -20,7 +20,7 @@
/* Verify the HOBs */ if (hob_list_ptr == NULL) { - printk(BIOS_ERR, "ERROR - HOB pointer is NULL!\n"); + printk(BIOS_ERR, "HOB pointer is NULL!\n"); return; }
@@ -41,8 +41,7 @@ !get_next_guid_hob(&graphics_info_guid, hob_list_ptr) && CONFIG(DISPLAY_HOBS)) { printk(BIOS_ERR, "7.5: EFI_PEI_GRAPHICS_INFO_HOB missing!\n"); - printk(BIOS_ERR, - "ERROR - Missing one or more required FSP HOBs!\n"); + printk(BIOS_ERR, "Missing one or more required FSP HOBs!\n"); } }