Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50267 )
Change subject: mb/emulation/qemu-q35: Mark TSEG region as reserved
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/emulation/qemu-i440fx/northbridge.c:
https://review.coreboot.org/c/coreboot/+/50267/comment/5eaa2172_552c5bd8
PS1, Line 109: CONFIG(BOARD_EMULATION_QEMU_X86_Q35)
Done
Argh, looks like the builds fail because smm_region() is not defined for i440fx...
You could move this to mb/emulation/qemu-q35/mainboard.c function qemu_nb_read_resources()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ae3659349d2a88bc3575fe9675433c054e28832
Gerrit-Change-Number: 50267
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 18:03:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment