You-Cheng Syu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33356
Change subject: google/kukui: Enable RTC ......................................................................
google/kukui: Enable RTC
Enable RTC so that we can see correct timestamp in CrOS eventlogs.
BUG=b:134461866 TEST='mosys eventlog list' shows correct timestamp on Kukui
Change-Id: Ie9ef7c9343c781e348429cd5376a4a5519641e16 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/33356/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 6831d1e..7719506 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -25,6 +25,7 @@
config BOARD_SPECIFIC_OPTIONS def_bool y + select RTC select SOC_MEDIATEK_MT8183 select BOARD_ROMSIZE_KB_8192 select MAINBOARD_HAS_CHROMEOS
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33356
to look at the new patch set (#2).
Change subject: google/kukui: Enable RTC ......................................................................
google/kukui: Enable RTC
Enable RTC so that we can see correct timestamp in CrOS eventlogs.
BUG=b:134461866 TEST='mosys eventlog list' shows correct timestamp on Kukui
Change-Id: Ie9ef7c9343c781e348429cd5376a4a5519641e16 Signed-off-by: You-Cheng Syu youcheng@google.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/33356/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33356 )
Change subject: google/kukui: Enable RTC ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33356 )
Change subject: google/kukui: Enable RTC ......................................................................
Patch Set 2:
d
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33356 )
Change subject: google/kukui: Enable RTC ......................................................................
google/kukui: Enable RTC
Enable RTC so that we can see correct timestamp in CrOS eventlogs.
BUG=b:134461866 TEST='mosys eventlog list' shows correct timestamp on Kukui
Change-Id: Ie9ef7c9343c781e348429cd5376a4a5519641e16 Signed-off-by: You-Cheng Syu youcheng@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33356 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 6831d1e..7719506 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -25,6 +25,7 @@
config BOARD_SPECIFIC_OPTIONS def_bool y + select RTC select SOC_MEDIATEK_MT8183 select BOARD_ROMSIZE_KB_8192 select MAINBOARD_HAS_CHROMEOS
-
Hung-Te Lin (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
You-Cheng Syu (Code Review)