Attention is currently required from: Paul Menzel, Stefan Reinauer, Werner Zeh. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52265 )
Change subject: Documentation/gerrit: Document our Gerrit user roles and procedures ......................................................................
Patch Set 4:
(2 comments)
File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/52265/comment/4c46d8e7_449fcc38 PS2, Line 347: by themselves or others, : at the regular [coreboot leadership meetings](../community/forums.md) : where a decision is made.
I think that is not needed, and is overkill. […]
The idea behind this is to provide some checks & balances, otherwise we might at some point have blanket inclusion of @$company.com (for some $company) because one core developer was "asked" to add more folks. This is supposed to protect both core developers from undue pressure and the community from the fallout...
File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/52265/comment/82cecac3_bb1ef040 PS4, Line 346: To become part of this group, : a candidate developer should be nominated,
Shall we add here that the candidate needs to be in the reviewer list before promoting? This is kind […]
I can't think of a scenario where we wouldn't have this kind of progression, so I guess we can add that requirement.