Change in coreboot[master]: mb/portwell/m107/fadt.c Use get_apic_table_revision

[Wim Vervoorn (Code Review)]

Hello Frans Hendriks,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/37612

to review the following change.

Change subject: mb/portwell/m107/fadt.c Use get_apic_table_revision
......................................................................

mb/portwell/m107/fadt.c Use get_apic_table_revision

Fixed value of ACPI_FADT_REV_ACPI_2_0 is replaced by
get_acpi_table_revision().

BUG=N/A
TEST=build

Change-Id: I95b0d886b73f94bc880c0e3e7d512211d2d33e21
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/portwell/m107/fadt.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/37612/1

diff --git a/src/mainboard/portwell/m107/fadt.c b/src/mainboard/portwell/m107/fadt.c
index 82986f6..544d24b 100644
--- a/src/mainboard/portwell/m107/fadt.c
+++ b/src/mainboard/portwell/m107/fadt.c
@@ -25,7 +25,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = ACPI_FADT_REV_ACPI_2_0;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37612 )

Change subject: mb/portwell/m107/fadt.c Use get_apic_table_revision
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37612 )

Change subject: mb/portwell/m107/fadt.c Use get_apic_table_revision
......................................................................

mb/portwell/m107/fadt.c Use get_apic_table_revision

Fixed value of ACPI_FADT_REV_ACPI_2_0 is replaced by
get_acpi_table_revision().

BUG=N/A
TEST=build

Change-Id: I95b0d886b73f94bc880c0e3e7d512211d2d33e21
Signed-off-by: Wim Vervoorn 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37612
Tested-by: build bot (Jenkins) 
Reviewed-by: Frans Hendriks 
---
M src/mainboard/portwell/m107/fadt.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Frans Hendriks: Looks good to me, approved

diff --git a/src/mainboard/portwell/m107/fadt.c b/src/mainboard/portwell/m107/fadt.c
index 82986f6..544d24b 100644
--- a/src/mainboard/portwell/m107/fadt.c
+++ b/src/mainboard/portwell/m107/fadt.c
@@ -25,7 +25,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = ACPI_FADT_REV_ACPI_2_0;
+	header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);