Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Rizwan Qureshi, Meera Ravindranath, EricR Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52013 )
Change subject: mb/google/brya: Enable WFC
......................................................................
Patch Set 7:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52013/comment/1f8cb7a8_ea9ca139
PS6, Line 10: 2. Add support OVTI8856
support for …
Done
https://review.coreboot.org/c/coreboot/+/52013/comment/9d241d11_bd787319
PS6, Line 13: BUG=None
Please add a blank line above.
Done
https://review.coreboot.org/c/coreboot/+/52013/comment/94a28dea_0b1e782c
PS6, Line 15: Boot
boot
Done
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52013/comment/b1a28d3e_3678a482
PS4, Line 169: register "link_freq[0]" = "360000000" # 360 MHz
`360 * MHz`
Done
https://review.coreboot.org/c/coreboot/+/52013/comment/97a78218_40d544d5
PS4, Line 170: 180000000
`180 * MHz`
Done
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52013/comment/d6510260_0db7f411
PS6, Line 234:
Please remove, or separate it out of this commit.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52013
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e9c28f255bdf86a68ce80a4f853be4e7c7ccfe
Gerrit-Change-Number: 52013
Gerrit-PatchSet: 7
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Shobhit Srivastava
shobhit.srivastava@intel.com
Gerrit-CC: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 May 2021 04:23:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya
varshit.b.pandya@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment