HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41817 )
Change subject: src: Remove redundant includes ......................................................................
src: Remove redundant includes
<types.h> is supposed to provide <commonlib/bsd/cb_err.h>, <stdbool.h>,<stdint.h> and <stddef.h>. So remove those includes each time when <types.h> is included.
Change-Id: I886f02255099f3005852a2e6095b21ca86a940ed Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/armv7/exception.c M src/arch/arm64/armv8/exception.c M src/device/pci_device.c M src/drivers/i2c/tpm/tpm.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/tpm/tpm.c M src/drivers/uart/pl011.h M src/ec/google/wilco/commands.h M src/ec/google/wilco/mailbox.c M src/include/device/dram/ddr3.h M src/include/device/dram/ddr4.h M src/include/lib.h M src/mainboard/supermicro/x10slm-f/mainboard.c M src/northbridge/intel/x4x/dq_dqs.c M src/security/tpm/tss.h M src/security/tpm/tss/tcg-2.0/tss_structures.h M src/soc/amd/common/block/include/amdblocks/acpimmio.h M src/soc/amd/common/block/include/amdblocks/lpc.h M src/soc/amd/common/block/lpc/espi_util.c M src/soc/cavium/cn81xx/include/soc/soc.h M src/soc/cavium/cn81xx/include/soc/timer.h M src/soc/cavium/cn81xx/include/soc/uart.h M src/soc/intel/apollolake/graphics.c M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/mediatek/mt8173/flash_controller.c M src/soc/mediatek/mt8173/include/soc/dramc_register.h M src/soc/mediatek/mt8173/include/soc/emi.h M src/soc/mediatek/mt8183/include/soc/emi.h M src/soc/mediatek/mt8183/include/soc/spm.h M src/soc/nvidia/tegra/dc.h M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/include/soc/dma.h M src/soc/nvidia/tegra210/spi.c 33 files changed, 2 insertions(+), 34 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/41817/1
diff --git a/src/arch/arm/armv7/exception.c b/src/arch/arm/armv7/exception.c index 39ef16d..799ae02 100644 --- a/src/arch/arm/armv7/exception.c +++ b/src/arch/arm/armv7/exception.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause */
-#include <stdint.h> #include <types.h> #include <arch/cache.h> #include <arch/exception.h> diff --git a/src/arch/arm64/armv8/exception.c b/src/arch/arm64/armv8/exception.c index db399fe..88e68e7 100644 --- a/src/arch/arm64/armv8/exception.c +++ b/src/arch/arm64/armv8/exception.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause */
-#include <stdint.h> #include <types.h> #include <arch/barrier.h> #include <arch/exception.h> diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 5f50a31..d9f65e6 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -11,7 +11,6 @@ #include <console/console.h> #include <cpu/cpu.h> #include <stdlib.h> -#include <stdint.h> #include <string.h> #include <delay.h> #include <device/cardbus.h> diff --git a/src/drivers/i2c/tpm/tpm.c b/src/drivers/i2c/tpm/tpm.c index 41d4577..78ac224 100644 --- a/src/drivers/i2c/tpm/tpm.c +++ b/src/drivers/i2c/tpm/tpm.c @@ -17,7 +17,6 @@
#include <commonlib/endian.h> -#include <stdint.h> #include <string.h> #include <types.h> #include <delay.h> diff --git a/src/drivers/intel/fsp2_0/include/fsp/info_header.h b/src/drivers/intel/fsp2_0/include/fsp/info_header.h index f6f66ce..7755d2a 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/info_header.h +++ b/src/drivers/intel/fsp2_0/include/fsp/info_header.h @@ -3,7 +3,6 @@ #ifndef _FSP2_0_INFO_HEADER_H_ #define _FSP2_0_INFO_HEADER_H_
-#include <stdint.h> #include <types.h>
#define FSP_HDR_OFFSET 0x94 diff --git a/src/drivers/tpm/tpm.c b/src/drivers/tpm/tpm.c index ad4a54c..d3485bb 100644 --- a/src/drivers/tpm/tpm.c +++ b/src/drivers/tpm/tpm.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <types.h> -#include <stddef.h> #include <bootstate.h> #include <security/tpm/tspi.h>
diff --git a/src/drivers/uart/pl011.h b/src/drivers/uart/pl011.h index 7b573a4..d4d54c4 100644 --- a/src/drivers/uart/pl011.h +++ b/src/drivers/uart/pl011.h @@ -7,7 +7,6 @@ #ifndef __DRIVERS_UART_PL011_H #define __DRIVERS_UART_PL011_H
-#include <stdint.h> #include <types.h>
/* PL011 r1p5 registers */ diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h index 912e88a..a216345 100644 --- a/src/ec/google/wilco/commands.h +++ b/src/ec/google/wilco/commands.h @@ -3,7 +3,6 @@ #ifndef EC_GOOGLE_WILCO_COMMANDS_H #define EC_GOOGLE_WILCO_COMMANDS_H
-#include <stdint.h> #include <types.h>
enum { diff --git a/src/ec/google/wilco/mailbox.c b/src/ec/google/wilco/mailbox.c index c592d81..f7aac86 100644 --- a/src/ec/google/wilco/mailbox.c +++ b/src/ec/google/wilco/mailbox.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <delay.h> #include <ec/google/common/mec.h> -#include <stdint.h> #include <string.h> #include <timer.h> #include <types.h> diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h index 08b7b7c..a209e48 100644 --- a/src/include/device/dram/ddr3.h +++ b/src/include/device/dram/ddr3.h @@ -15,7 +15,6 @@ * \brief Utilities for decoding DDR3 SPDs */
-#include <stdint.h> #include <spd.h> #include <device/dram/common.h> #include <types.h> diff --git a/src/include/device/dram/ddr4.h b/src/include/device/dram/ddr4.h index 51fd7bf..f258fa9 100644 --- a/src/include/device/dram/ddr4.h +++ b/src/include/device/dram/ddr4.h @@ -14,7 +14,6 @@ * \brief Utilities for decoding DDR4 SPDs */
-#include <stdint.h> #include <spd.h> #include <device/dram/common.h> #include <types.h> diff --git a/src/include/lib.h b/src/include/lib.h index d7b6b14..0d6fdb1 100644 --- a/src/include/lib.h +++ b/src/include/lib.h @@ -4,7 +4,7 @@
#ifndef __LIB_H__ #define __LIB_H__ -#include <stdint.h> + #include <types.h>
/* Defined in src/lib/lzma.c. Returns decompressed size or 0 on error. */ diff --git a/src/mainboard/supermicro/x10slm-f/mainboard.c b/src/mainboard/supermicro/x10slm-f/mainboard.c index 7d840f5..2f20606 100644 --- a/src/mainboard/supermicro/x10slm-f/mainboard.c +++ b/src/mainboard/supermicro/x10slm-f/mainboard.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <option.h> -#include <stdint.h> #include <types.h>
/* diff --git a/src/northbridge/intel/x4x/dq_dqs.c b/src/northbridge/intel/x4x/dq_dqs.c index 7df2591..dda4174 100644 --- a/src/northbridge/intel/x4x/dq_dqs.c +++ b/src/northbridge/intel/x4x/dq_dqs.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <console/console.h> #include <delay.h> -#include <stdint.h> #include <string.h> #include <types.h> #include "x4x.h" diff --git a/src/security/tpm/tss.h b/src/security/tpm/tss.h index 57f3b24..f39b0f5 100644 --- a/src/security/tpm/tss.h +++ b/src/security/tpm/tss.h @@ -13,7 +13,6 @@ #ifndef TSS_H_ #define TSS_H_
-#include <stdint.h> #include <types.h>
#include <security/tpm/tss/common/tss_common.h> diff --git a/src/security/tpm/tss/tcg-2.0/tss_structures.h b/src/security/tpm/tss/tcg-2.0/tss_structures.h index 3f0c654..c267ec9 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_structures.h +++ b/src/security/tpm/tss/tcg-2.0/tss_structures.h @@ -11,7 +11,6 @@ * This file includes a subset of definitions of TPM protocol version 2.x * constants and structures needed for functions used in coreboot. */ -#include <stdint.h> #include <types.h> #include "../common/tss_common.h"
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index 0d41782..84a9360 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -4,7 +4,6 @@ #define __AMDBLOCKS_ACPIMMIO_H__
#include <device/mmio.h> -#include <stdint.h> #include <types.h> #include <amdblocks/acpimmio_map.h>
diff --git a/src/soc/amd/common/block/include/amdblocks/lpc.h b/src/soc/amd/common/block/include/amdblocks/lpc.h index 11acc78..7412e7b 100644 --- a/src/soc/amd/common/block/include/amdblocks/lpc.h +++ b/src/soc/amd/common/block/include/amdblocks/lpc.h @@ -4,7 +4,6 @@ #define __AMDBLOCKS_LPC_H__
#include <types.h> -#include <stdint.h>
/* PCI registers for D14F3 */ #define LPC_PCI_CONTROL 0x40 diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 5ca0d28..3750a8b 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -7,8 +7,6 @@ #include <console/console.h> #include <espi.h> #include <soc/pci_devs.h> -#include <stddef.h> -#include <stdint.h> #include <timer.h> #include <types.h>
diff --git a/src/soc/cavium/cn81xx/include/soc/soc.h b/src/soc/cavium/cn81xx/include/soc/soc.h index 3939517..78343fd 100644 --- a/src/soc/cavium/cn81xx/include/soc/soc.h +++ b/src/soc/cavium/cn81xx/include/soc/soc.h @@ -3,7 +3,6 @@ #ifndef __SOC_CAVIUM_CN81XX_INCLUDE_SOC_SOC_H #define __SOC_CAVIUM_CN81XX_INCLUDE_SOC_SOC_H
-#include <stdint.h> #include <types.h>
/* MIO BOOT Registers */ diff --git a/src/soc/cavium/cn81xx/include/soc/timer.h b/src/soc/cavium/cn81xx/include/soc/timer.h index 99dbb6a..d722569 100644 --- a/src/soc/cavium/cn81xx/include/soc/timer.h +++ b/src/soc/cavium/cn81xx/include/soc/timer.h @@ -3,7 +3,6 @@ #ifndef __SOC_CAVIUM_CN81XX_TIMER_H__ #define __SOC_CAVIUM_CN81XX_TIMER_H__
-#include <stdint.h> #include <types.h>
/* Watchdog functions */ diff --git a/src/soc/cavium/cn81xx/include/soc/uart.h b/src/soc/cavium/cn81xx/include/soc/uart.h index db1a51e..afafd0e 100644 --- a/src/soc/cavium/cn81xx/include/soc/uart.h +++ b/src/soc/cavium/cn81xx/include/soc/uart.h @@ -3,7 +3,6 @@ #ifndef __SOC_CAVIUM_COMMON_INCLUDE_SOC_UART_H #define __SOC_CAVIUM_COMMON_INCLUDE_SOC_UART_H
-#include <stdint.h> #include <types.h>
int uart_is_enabled(const size_t bus); diff --git a/src/soc/intel/apollolake/graphics.c b/src/soc/intel/apollolake/graphics.c index a5e361e..2fc0376 100644 --- a/src/soc/intel/apollolake/graphics.c +++ b/src/soc/intel/apollolake/graphics.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#include <stdint.h> #include <acpi/acpi.h> #include <bootmode.h> #include <console/console.h> diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index 9f85730..a1dc3d9 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -3,7 +3,6 @@ #ifndef SOC_INTEL_COMMON_CSE_H #define SOC_INTEL_COMMON_CSE_H
-#include <stdint.h> #include <types.h>
/* MKHI Command groups */ diff --git a/src/soc/mediatek/mt8173/flash_controller.c b/src/soc/mediatek/mt8173/flash_controller.c index c1f2dae..64eff2e 100644 --- a/src/soc/mediatek/mt8173/flash_controller.c +++ b/src/soc/mediatek/mt8173/flash_controller.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <spi_flash.h> #include <spi-generic.h> -#include <stdint.h> #include <string.h> #include <symbols.h> #include <timer.h> diff --git a/src/soc/mediatek/mt8173/include/soc/dramc_register.h b/src/soc/mediatek/mt8173/include/soc/dramc_register.h index 5841b24..cabc1dc 100644 --- a/src/soc/mediatek/mt8173/include/soc/dramc_register.h +++ b/src/soc/mediatek/mt8173/include/soc/dramc_register.h @@ -3,7 +3,6 @@ #ifndef _DRAMC_REGISTER_H_ #define _DRAMC_REGISTER_H_
-#include <stddef.h> #include <types.h>
#define DRIVING_DS2_0 7 /* DS[2:0] 7->6 */ diff --git a/src/soc/mediatek/mt8173/include/soc/emi.h b/src/soc/mediatek/mt8173/include/soc/emi.h index 8f12ee3..1cc2577 100644 --- a/src/soc/mediatek/mt8173/include/soc/emi.h +++ b/src/soc/mediatek/mt8173/include/soc/emi.h @@ -4,7 +4,6 @@ #define SOC_MEDIATEK_MT8173_EMI_H
#include <soc/dramc_common.h> -#include <stdint.h> #include <types.h>
/* DDR type */ diff --git a/src/soc/mediatek/mt8183/include/soc/emi.h b/src/soc/mediatek/mt8183/include/soc/emi.h index e775973..b2d78b9 100644 --- a/src/soc/mediatek/mt8183/include/soc/emi.h +++ b/src/soc/mediatek/mt8183/include/soc/emi.h @@ -3,7 +3,6 @@ #ifndef SOC_MEDIATEK_MT8183_EMI_H #define SOC_MEDIATEK_MT8183_EMI_H
-#include <stdint.h> #include <types.h> #include <soc/dramc_common_mt8183.h>
diff --git a/src/soc/mediatek/mt8183/include/soc/spm.h b/src/soc/mediatek/mt8183/include/soc/spm.h index e09d451..fa6d6d0 100644 --- a/src/soc/mediatek/mt8183/include/soc/spm.h +++ b/src/soc/mediatek/mt8183/include/soc/spm.h @@ -4,7 +4,6 @@ #define SOC_MEDIATEK_MT8183_SPM_H
#include <soc/addressmap.h> -#include <stdint.h> #include <types.h>
/* SPM READ/WRITE CFG */ diff --git a/src/soc/nvidia/tegra/dc.h b/src/soc/nvidia/tegra/dc.h index f0f5b11..27bbee8 100644 --- a/src/soc/nvidia/tegra/dc.h +++ b/src/soc/nvidia/tegra/dc.h @@ -2,8 +2,8 @@
#ifndef __SOC_NVIDIA_TEGRA_DC_H #define __SOC_NVIDIA_TEGRA_DC_H + #include <device/device.h> -#include <stddef.h> #include <types.h>
/* Register definitions for the Tegra display controller */ diff --git a/src/soc/nvidia/tegra124/spi.c b/src/soc/nvidia/tegra124/spi.c index 6a25721..adf0248 100644 --- a/src/soc/nvidia/tegra124/spi.c +++ b/src/soc/nvidia/tegra124/spi.c @@ -7,7 +7,6 @@ #include <boot_device.h> #include <console/console.h> #include <delay.h> -#include <stdint.h> #include <soc/addressmap.h> #include <soc/dma.h> #include <soc/spi.h> diff --git a/src/soc/nvidia/tegra210/include/soc/dma.h b/src/soc/nvidia/tegra210/include/soc/dma.h index 3add2ba..b06cec6 100644 --- a/src/soc/nvidia/tegra210/include/soc/dma.h +++ b/src/soc/nvidia/tegra210/include/soc/dma.h @@ -3,7 +3,6 @@ #ifndef __NVIDIA_TEGRA210_DMA_H__ #define __NVIDIA_TEGRA210_DMA_H__
-#include <stdint.h> #include <soc/addressmap.h> #include <types.h>
diff --git a/src/soc/nvidia/tegra210/spi.c b/src/soc/nvidia/tegra210/spi.c index eae8f39..8fde9c2 100644 --- a/src/soc/nvidia/tegra210/spi.c +++ b/src/soc/nvidia/tegra210/spi.c @@ -7,7 +7,6 @@ #include <boot_device.h> #include <console/console.h> #include <delay.h> -#include <stdint.h> #include <spi-generic.h> #include <spi_flash.h> #include <soc/addressmap.h>
Hello Damien Zammit, Tristan Corrick, Christian Walter, Julius Werner, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41817
to look at the new patch set (#2).
Change subject: src: Remove redundant includes ......................................................................
src: Remove redundant includes
<types.h> is supposed to provide <commonlib/bsd/cb_err.h>, <stdbool.h>,<stdint.h> and <stddef.h>. So remove those includes each time when <types.h> is included.
Change-Id: I886f02255099f3005852a2e6095b21ca86a940ed Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/armv7/exception.c M src/arch/arm64/armv8/exception.c M src/device/pci_device.c M src/drivers/i2c/tpm/tpm.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/tpm/tpm.c M src/drivers/uart/pl011.h M src/ec/google/wilco/commands.h M src/ec/google/wilco/mailbox.c M src/include/device/dram/ddr3.h M src/include/device/dram/ddr4.h M src/include/lib.h M src/mainboard/supermicro/x10slm-f/mainboard.c M src/northbridge/intel/x4x/dq_dqs.c M src/security/tpm/tss.h M src/security/tpm/tss/tcg-2.0/tss_structures.h M src/soc/amd/common/block/include/amdblocks/acpimmio.h M src/soc/amd/common/block/include/amdblocks/lpc.h M src/soc/amd/common/block/lpc/espi_util.c M src/soc/cavium/cn81xx/include/soc/soc.h M src/soc/cavium/cn81xx/include/soc/timer.h M src/soc/cavium/cn81xx/include/soc/uart.h M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/mediatek/mt8173/flash_controller.c M src/soc/mediatek/mt8173/include/soc/dramc_register.h M src/soc/mediatek/mt8173/include/soc/emi.h M src/soc/mediatek/mt8183/include/soc/emi.h M src/soc/mediatek/mt8183/include/soc/spm.h M src/soc/nvidia/tegra/dc.h M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/include/soc/dma.h M src/soc/nvidia/tegra210/spi.c 32 files changed, 2 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/41817/2
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41817 )
Change subject: src: Remove redundant includes ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41817 )
Change subject: src: Remove redundant includes ......................................................................
Patch Set 2: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41817 )
Change subject: src: Remove redundant includes ......................................................................
src: Remove redundant includes
<types.h> is supposed to provide <commonlib/bsd/cb_err.h>, <stdbool.h>,<stdint.h> and <stddef.h>. So remove those includes each time when <types.h> is included.
Change-Id: I886f02255099f3005852a2e6095b21ca86a940ed Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41817 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/arch/arm/armv7/exception.c M src/arch/arm64/armv8/exception.c M src/device/pci_device.c M src/drivers/i2c/tpm/tpm.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/tpm/tpm.c M src/drivers/uart/pl011.h M src/ec/google/wilco/commands.h M src/ec/google/wilco/mailbox.c M src/include/device/dram/ddr3.h M src/include/device/dram/ddr4.h M src/include/lib.h M src/mainboard/supermicro/x10slm-f/mainboard.c M src/northbridge/intel/x4x/dq_dqs.c M src/security/tpm/tss.h M src/security/tpm/tss/tcg-2.0/tss_structures.h M src/soc/amd/common/block/include/amdblocks/acpimmio.h M src/soc/amd/common/block/include/amdblocks/lpc.h M src/soc/amd/common/block/lpc/espi_util.c M src/soc/cavium/cn81xx/include/soc/soc.h M src/soc/cavium/cn81xx/include/soc/timer.h M src/soc/cavium/cn81xx/include/soc/uart.h M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/mediatek/mt8173/flash_controller.c M src/soc/mediatek/mt8173/include/soc/dramc_register.h M src/soc/mediatek/mt8173/include/soc/emi.h M src/soc/mediatek/mt8183/include/soc/emi.h M src/soc/mediatek/mt8183/include/soc/spm.h M src/soc/nvidia/tegra/dc.h M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/include/soc/dma.h M src/soc/nvidia/tegra210/spi.c 32 files changed, 2 insertions(+), 33 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Julius Werner: Looks good to me, approved
diff --git a/src/arch/arm/armv7/exception.c b/src/arch/arm/armv7/exception.c index 39ef16d..799ae02 100644 --- a/src/arch/arm/armv7/exception.c +++ b/src/arch/arm/armv7/exception.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause */
-#include <stdint.h> #include <types.h> #include <arch/cache.h> #include <arch/exception.h> diff --git a/src/arch/arm64/armv8/exception.c b/src/arch/arm64/armv8/exception.c index db399fe..88e68e7 100644 --- a/src/arch/arm64/armv8/exception.c +++ b/src/arch/arm64/armv8/exception.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause */
-#include <stdint.h> #include <types.h> #include <arch/barrier.h> #include <arch/exception.h> diff --git a/src/device/pci_device.c b/src/device/pci_device.c index e6c6ff3..f83520e 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -11,7 +11,6 @@ #include <console/console.h> #include <cpu/cpu.h> #include <stdlib.h> -#include <stdint.h> #include <string.h> #include <delay.h> #include <device/cardbus.h> diff --git a/src/drivers/i2c/tpm/tpm.c b/src/drivers/i2c/tpm/tpm.c index 41d4577..78ac224 100644 --- a/src/drivers/i2c/tpm/tpm.c +++ b/src/drivers/i2c/tpm/tpm.c @@ -17,7 +17,6 @@
#include <commonlib/endian.h> -#include <stdint.h> #include <string.h> #include <types.h> #include <delay.h> diff --git a/src/drivers/intel/fsp2_0/include/fsp/info_header.h b/src/drivers/intel/fsp2_0/include/fsp/info_header.h index f6f66ce..7755d2a 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/info_header.h +++ b/src/drivers/intel/fsp2_0/include/fsp/info_header.h @@ -3,7 +3,6 @@ #ifndef _FSP2_0_INFO_HEADER_H_ #define _FSP2_0_INFO_HEADER_H_
-#include <stdint.h> #include <types.h>
#define FSP_HDR_OFFSET 0x94 diff --git a/src/drivers/tpm/tpm.c b/src/drivers/tpm/tpm.c index ad4a54c..d3485bb 100644 --- a/src/drivers/tpm/tpm.c +++ b/src/drivers/tpm/tpm.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <types.h> -#include <stddef.h> #include <bootstate.h> #include <security/tpm/tspi.h>
diff --git a/src/drivers/uart/pl011.h b/src/drivers/uart/pl011.h index 7b573a4..d4d54c4 100644 --- a/src/drivers/uart/pl011.h +++ b/src/drivers/uart/pl011.h @@ -7,7 +7,6 @@ #ifndef __DRIVERS_UART_PL011_H #define __DRIVERS_UART_PL011_H
-#include <stdint.h> #include <types.h>
/* PL011 r1p5 registers */ diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h index 912e88a..a216345 100644 --- a/src/ec/google/wilco/commands.h +++ b/src/ec/google/wilco/commands.h @@ -3,7 +3,6 @@ #ifndef EC_GOOGLE_WILCO_COMMANDS_H #define EC_GOOGLE_WILCO_COMMANDS_H
-#include <stdint.h> #include <types.h>
enum { diff --git a/src/ec/google/wilco/mailbox.c b/src/ec/google/wilco/mailbox.c index c592d81..f7aac86 100644 --- a/src/ec/google/wilco/mailbox.c +++ b/src/ec/google/wilco/mailbox.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <delay.h> #include <ec/google/common/mec.h> -#include <stdint.h> #include <string.h> #include <timer.h> #include <types.h> diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h index 08b7b7c..a209e48 100644 --- a/src/include/device/dram/ddr3.h +++ b/src/include/device/dram/ddr3.h @@ -15,7 +15,6 @@ * \brief Utilities for decoding DDR3 SPDs */
-#include <stdint.h> #include <spd.h> #include <device/dram/common.h> #include <types.h> diff --git a/src/include/device/dram/ddr4.h b/src/include/device/dram/ddr4.h index 51fd7bf..f258fa9 100644 --- a/src/include/device/dram/ddr4.h +++ b/src/include/device/dram/ddr4.h @@ -14,7 +14,6 @@ * \brief Utilities for decoding DDR4 SPDs */
-#include <stdint.h> #include <spd.h> #include <device/dram/common.h> #include <types.h> diff --git a/src/include/lib.h b/src/include/lib.h index d7b6b14..0d6fdb1 100644 --- a/src/include/lib.h +++ b/src/include/lib.h @@ -4,7 +4,7 @@
#ifndef __LIB_H__ #define __LIB_H__ -#include <stdint.h> + #include <types.h>
/* Defined in src/lib/lzma.c. Returns decompressed size or 0 on error. */ diff --git a/src/mainboard/supermicro/x10slm-f/mainboard.c b/src/mainboard/supermicro/x10slm-f/mainboard.c index 7d840f5..2f20606 100644 --- a/src/mainboard/supermicro/x10slm-f/mainboard.c +++ b/src/mainboard/supermicro/x10slm-f/mainboard.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <option.h> -#include <stdint.h> #include <types.h>
/* diff --git a/src/northbridge/intel/x4x/dq_dqs.c b/src/northbridge/intel/x4x/dq_dqs.c index 7df2591..dda4174 100644 --- a/src/northbridge/intel/x4x/dq_dqs.c +++ b/src/northbridge/intel/x4x/dq_dqs.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <console/console.h> #include <delay.h> -#include <stdint.h> #include <string.h> #include <types.h> #include "x4x.h" diff --git a/src/security/tpm/tss.h b/src/security/tpm/tss.h index f644e3e..4a8206d0 100644 --- a/src/security/tpm/tss.h +++ b/src/security/tpm/tss.h @@ -9,7 +9,6 @@ #ifndef TSS_H_ #define TSS_H_
-#include <stdint.h> #include <types.h>
#include <security/tpm/tss/common/tss_common.h> diff --git a/src/security/tpm/tss/tcg-2.0/tss_structures.h b/src/security/tpm/tss/tcg-2.0/tss_structures.h index f8c6012..1c7aa4b 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_structures.h +++ b/src/security/tpm/tss/tcg-2.0/tss_structures.h @@ -7,7 +7,6 @@ * This file includes a subset of definitions of TPM protocol version 2.x * constants and structures needed for functions used in coreboot. */ -#include <stdint.h> #include <types.h> #include "../common/tss_common.h"
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index 0d41782..84a9360 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -4,7 +4,6 @@ #define __AMDBLOCKS_ACPIMMIO_H__
#include <device/mmio.h> -#include <stdint.h> #include <types.h> #include <amdblocks/acpimmio_map.h>
diff --git a/src/soc/amd/common/block/include/amdblocks/lpc.h b/src/soc/amd/common/block/include/amdblocks/lpc.h index 11acc78..7412e7b 100644 --- a/src/soc/amd/common/block/include/amdblocks/lpc.h +++ b/src/soc/amd/common/block/include/amdblocks/lpc.h @@ -4,7 +4,6 @@ #define __AMDBLOCKS_LPC_H__
#include <types.h> -#include <stdint.h>
/* PCI registers for D14F3 */ #define LPC_PCI_CONTROL 0x40 diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 5ca0d28..3750a8b 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -7,8 +7,6 @@ #include <console/console.h> #include <espi.h> #include <soc/pci_devs.h> -#include <stddef.h> -#include <stdint.h> #include <timer.h> #include <types.h>
diff --git a/src/soc/cavium/cn81xx/include/soc/soc.h b/src/soc/cavium/cn81xx/include/soc/soc.h index 3939517..78343fd 100644 --- a/src/soc/cavium/cn81xx/include/soc/soc.h +++ b/src/soc/cavium/cn81xx/include/soc/soc.h @@ -3,7 +3,6 @@ #ifndef __SOC_CAVIUM_CN81XX_INCLUDE_SOC_SOC_H #define __SOC_CAVIUM_CN81XX_INCLUDE_SOC_SOC_H
-#include <stdint.h> #include <types.h>
/* MIO BOOT Registers */ diff --git a/src/soc/cavium/cn81xx/include/soc/timer.h b/src/soc/cavium/cn81xx/include/soc/timer.h index 99dbb6a..d722569 100644 --- a/src/soc/cavium/cn81xx/include/soc/timer.h +++ b/src/soc/cavium/cn81xx/include/soc/timer.h @@ -3,7 +3,6 @@ #ifndef __SOC_CAVIUM_CN81XX_TIMER_H__ #define __SOC_CAVIUM_CN81XX_TIMER_H__
-#include <stdint.h> #include <types.h>
/* Watchdog functions */ diff --git a/src/soc/cavium/cn81xx/include/soc/uart.h b/src/soc/cavium/cn81xx/include/soc/uart.h index db1a51e..afafd0e 100644 --- a/src/soc/cavium/cn81xx/include/soc/uart.h +++ b/src/soc/cavium/cn81xx/include/soc/uart.h @@ -3,7 +3,6 @@ #ifndef __SOC_CAVIUM_COMMON_INCLUDE_SOC_UART_H #define __SOC_CAVIUM_COMMON_INCLUDE_SOC_UART_H
-#include <stdint.h> #include <types.h>
int uart_is_enabled(const size_t bus); diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index 9f85730..a1dc3d9 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -3,7 +3,6 @@ #ifndef SOC_INTEL_COMMON_CSE_H #define SOC_INTEL_COMMON_CSE_H
-#include <stdint.h> #include <types.h>
/* MKHI Command groups */ diff --git a/src/soc/mediatek/mt8173/flash_controller.c b/src/soc/mediatek/mt8173/flash_controller.c index c1f2dae..64eff2e 100644 --- a/src/soc/mediatek/mt8173/flash_controller.c +++ b/src/soc/mediatek/mt8173/flash_controller.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <spi_flash.h> #include <spi-generic.h> -#include <stdint.h> #include <string.h> #include <symbols.h> #include <timer.h> diff --git a/src/soc/mediatek/mt8173/include/soc/dramc_register.h b/src/soc/mediatek/mt8173/include/soc/dramc_register.h index 5841b24..cabc1dc 100644 --- a/src/soc/mediatek/mt8173/include/soc/dramc_register.h +++ b/src/soc/mediatek/mt8173/include/soc/dramc_register.h @@ -3,7 +3,6 @@ #ifndef _DRAMC_REGISTER_H_ #define _DRAMC_REGISTER_H_
-#include <stddef.h> #include <types.h>
#define DRIVING_DS2_0 7 /* DS[2:0] 7->6 */ diff --git a/src/soc/mediatek/mt8173/include/soc/emi.h b/src/soc/mediatek/mt8173/include/soc/emi.h index 8f12ee3..1cc2577 100644 --- a/src/soc/mediatek/mt8173/include/soc/emi.h +++ b/src/soc/mediatek/mt8173/include/soc/emi.h @@ -4,7 +4,6 @@ #define SOC_MEDIATEK_MT8173_EMI_H
#include <soc/dramc_common.h> -#include <stdint.h> #include <types.h>
/* DDR type */ diff --git a/src/soc/mediatek/mt8183/include/soc/emi.h b/src/soc/mediatek/mt8183/include/soc/emi.h index e775973..b2d78b9 100644 --- a/src/soc/mediatek/mt8183/include/soc/emi.h +++ b/src/soc/mediatek/mt8183/include/soc/emi.h @@ -3,7 +3,6 @@ #ifndef SOC_MEDIATEK_MT8183_EMI_H #define SOC_MEDIATEK_MT8183_EMI_H
-#include <stdint.h> #include <types.h> #include <soc/dramc_common_mt8183.h>
diff --git a/src/soc/mediatek/mt8183/include/soc/spm.h b/src/soc/mediatek/mt8183/include/soc/spm.h index e09d451..fa6d6d0 100644 --- a/src/soc/mediatek/mt8183/include/soc/spm.h +++ b/src/soc/mediatek/mt8183/include/soc/spm.h @@ -4,7 +4,6 @@ #define SOC_MEDIATEK_MT8183_SPM_H
#include <soc/addressmap.h> -#include <stdint.h> #include <types.h>
/* SPM READ/WRITE CFG */ diff --git a/src/soc/nvidia/tegra/dc.h b/src/soc/nvidia/tegra/dc.h index f0f5b11..27bbee8 100644 --- a/src/soc/nvidia/tegra/dc.h +++ b/src/soc/nvidia/tegra/dc.h @@ -2,8 +2,8 @@
#ifndef __SOC_NVIDIA_TEGRA_DC_H #define __SOC_NVIDIA_TEGRA_DC_H + #include <device/device.h> -#include <stddef.h> #include <types.h>
/* Register definitions for the Tegra display controller */ diff --git a/src/soc/nvidia/tegra124/spi.c b/src/soc/nvidia/tegra124/spi.c index 6a25721..adf0248 100644 --- a/src/soc/nvidia/tegra124/spi.c +++ b/src/soc/nvidia/tegra124/spi.c @@ -7,7 +7,6 @@ #include <boot_device.h> #include <console/console.h> #include <delay.h> -#include <stdint.h> #include <soc/addressmap.h> #include <soc/dma.h> #include <soc/spi.h> diff --git a/src/soc/nvidia/tegra210/include/soc/dma.h b/src/soc/nvidia/tegra210/include/soc/dma.h index 3add2ba..b06cec6 100644 --- a/src/soc/nvidia/tegra210/include/soc/dma.h +++ b/src/soc/nvidia/tegra210/include/soc/dma.h @@ -3,7 +3,6 @@ #ifndef __NVIDIA_TEGRA210_DMA_H__ #define __NVIDIA_TEGRA210_DMA_H__
-#include <stdint.h> #include <soc/addressmap.h> #include <types.h>
diff --git a/src/soc/nvidia/tegra210/spi.c b/src/soc/nvidia/tegra210/spi.c index eae8f39..8fde9c2 100644 --- a/src/soc/nvidia/tegra210/spi.c +++ b/src/soc/nvidia/tegra210/spi.c @@ -7,7 +7,6 @@ #include <boot_device.h> #include <console/console.h> #include <delay.h> -#include <stdint.h> #include <spi-generic.h> #include <spi_flash.h> #include <soc/addressmap.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41817 )
Change subject: src: Remove redundant includes ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4632 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4631 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4630 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4629
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
HAOUAS Elyes (Code Review)
-
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)