EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41494 )
Change subject: mb/google/deltaur: Add low power idle table ......................................................................
mb/google/deltaur: Add low power idle table
Add low power idle table to notify EC system is entering s0ix.
BUG=none TEST=Power button and Keyboard backlight are off when suspending.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Icf4dffe2bd289c15854bbad914c3b34b307254ec --- M src/mainboard/google/deltaur/dsdt.asl 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/41494/1
diff --git a/src/mainboard/google/deltaur/dsdt.asl b/src/mainboard/google/deltaur/dsdt.asl index 03067ae..e52c9f8 100644 --- a/src/mainboard/google/deltaur/dsdt.asl +++ b/src/mainboard/google/deltaur/dsdt.asl @@ -37,6 +37,9 @@ /* VPD support */ #include <vendorcode/google/chromeos/acpi/vpd.asl>
+ /* Low power idle table */ + #include <soc/intel/common/acpi/lpit.asl> + /* Chrome OS Embedded Controller */ Scope (_SB.PCI0.LPCB) {
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41494 )
Change subject: mb/google/deltaur: Add low power idle table ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41494/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41494/1//COMMIT_MSG@12 PS1, Line 12: Keyboard keyboard
Hello build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Bora Guvendik, Selma Bensaid,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41494
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Add low power idle table ......................................................................
mb/google/deltaur: Add low power idle table
Add low power idle table to notify EC system is entering s0ix.
BUG=none TEST=Power button and keyboard backlight are off when suspending.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Icf4dffe2bd289c15854bbad914c3b34b307254ec --- M src/mainboard/google/deltaur/dsdt.asl 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/41494/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41494 )
Change subject: mb/google/deltaur: Add low power idle table ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41494/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41494/1//COMMIT_MSG@12 PS1, Line 12: Keyboard
keyboard
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41494 )
Change subject: mb/google/deltaur: Add low power idle table ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41494 )
Change subject: mb/google/deltaur: Add low power idle table ......................................................................
mb/google/deltaur: Add low power idle table
Add low power idle table to notify EC system is entering s0ix.
BUG=none TEST=Power button and keyboard backlight are off when suspending.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Icf4dffe2bd289c15854bbad914c3b34b307254ec Reviewed-on: https://review.coreboot.org/c/coreboot/+/41494 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/deltaur/dsdt.asl 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/dsdt.asl b/src/mainboard/google/deltaur/dsdt.asl index b439d06..fe86e15 100644 --- a/src/mainboard/google/deltaur/dsdt.asl +++ b/src/mainboard/google/deltaur/dsdt.asl @@ -34,6 +34,9 @@ /* VPD support */ #include <vendorcode/google/chromeos/acpi/vpd.asl>
+ /* Low power idle table */ + #include <soc/intel/common/acpi/lpit.asl> + /* Chrome OS Embedded Controller */ Scope (_SB.PCI0.LPCB) {
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41494 )
Change subject: mb/google/deltaur: Add low power idle table ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3662 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3661 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3660 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3659
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
EricR Lai (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)