Shelley Chen has posted comments on this change. ( https://review.coreboot.org/19698 )
Change subject: detachables: Add invert parameter ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/19698/8/payloads/libpayload/drivers/video/gr... File payloads/libpayload/drivers/video/graphics.c:
PS8, Line 122: 00
Does the upper byte not matter?
I did this thinking each red, green, blue is a uint8_t value, so we don't actually set the top 8 bits. I didn't want to mess with the upper bits because we weren't actually setting them, but I just tried it and it didn't change the functionality. I suppose that if we ever change the layout of the color bits, having all Fs would make this function more flexible? Anyway, I changed it to all Fs. :)
-
Shelley Chen (Code Review)