Change in coreboot[master]: mb/google/hatch/var/dratini: Add a new sku for dragonair

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

20 Dec 2019 20 Dec '19

6:21 a.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

mb/google/hatch/var/dratini: Add a new sku for dragonair

Add a new sku for dragonair

BUG=b:146504217 TEST=emerge-hatch coreboot

Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/dratini/include/variant/sku.h M src/mainboard/google/hatch/variants/dratini/variant.c 2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/37864/1

diff --git a/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h b/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h index e36d335..ffa4cfb 100644 --- a/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h +++ b/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h @@ -20,6 +20,7 @@ SKU_21_DRAGONAIR = 21, /* TS + FPS + Stylus */ SKU_22_DRAGONAIR = 22, /* TS + KB_BL + FPS + Stylus */ SKU_23_DRAGONAIR = 23, /* TS + Stylus */ + SKU_24_DRAGONAIR = 24, };

#endif /* __MAINBOARD_SKU_H__ */ diff --git a/src/mainboard/google/hatch/variants/dratini/variant.c b/src/mainboard/google/hatch/variants/dratini/variant.c index 3a00385..3a51a55 100644 --- a/src/mainboard/google/hatch/variants/dratini/variant.c +++ b/src/mainboard/google/hatch/variants/dratini/variant.c @@ -26,6 +26,7 @@ case SKU_21_DRAGONAIR: case SKU_22_DRAGONAIR: case SKU_23_DRAGONAIR: + case SKU_24_DRAGONAIR: filename = "wifi_sar-dragonair.hex"; break; }

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Chen Wisley (Code Review)

20 Dec 20 Dec

2:17 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 1:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 20 Dec 2019 13:17:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

4:40 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/37864/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/include/variant/sku.h:

https://review.coreboot.org/c/coreboot/+/37864/1/src/mainboard/google/hatch/... PS1, Line 23: SKU_24_DRAGONAIR = 24, Nit: did you want to add a comment here about SKU 24 like you have for SKUs 21..23?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 20 Dec 2019 15:40:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Chen Wisley (Code Review)

5:21 p.m.

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37864

to look at the new patch set (#2).

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

mb/google/hatch/var/dratini: Add a new sku for dragonair

Add a new sku for dragonair

BUG=b:146504217 TEST=emerge-hatch coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/37864/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

5:22 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37864/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/include/variant/sku.h:

https://review.coreboot.org/c/coreboot/+/37864/1/src/mainboard/google/hatch/... PS1, Line 23: SKU_24_DRAGONAIR = 24,

...

Nit: did you want to add a comment here about SKU 24 like you have for SKUs 21.. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 20 Dec 2019 16:22:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Fagerburg pfagerburg@chromium.org Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

5:25 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 20 Dec 2019 16:25:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:17 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37864/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/include/variant/sku.h:

https://review.coreboot.org/c/coreboot/+/37864/2/src/mainboard/google/hatch/... PS2, Line 20: SKU_21_DRAGONAIR = 21, /* TS + FPS + Stylus */ : SKU_22_DRAGONAIR = 22, /* TS + KB_BL + FPS + Stylus */ : SKU_23_DRAGONAIR = 23, /* TS + Stylus */ : SKU_24_DRAGONAIR = 24, /* TS + KB_BL + Stylus */ Do you want all this HW information publicly available?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 20 Dec 2019 18:17:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

21 Dec 21 Dec

3:02 a.m.

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37864

to look at the new patch set (#3).

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

mb/google/hatch/var/dratini: Add a new sku for dragonair

Add a new sku for dragonair

BUG=b:146504217 TEST=emerge-hatch coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/37864/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

4:19 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37864/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/include/variant/sku.h:

...

Do you want all this HW information publicly available?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 21 Dec 2019 03:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

23 Dec 23 Dec

3:01 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 23 Dec 2019 14:01:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:53 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 23 Dec 2019 16:53:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

10:24 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37864/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/include/variant/sku.h:

https://review.coreboot.org/c/coreboot/+/37864/3/src/mainboard/google/hatch/... PS3, Line 19: enum { Why did the comments get dropped?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 23 Dec 2019 21:24:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

24 Dec 24 Dec

7:58 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37864/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/include/variant/sku.h:

https://review.coreboot.org/c/coreboot/+/37864/3/src/mainboard/google/hatch/... PS3, Line 19: enum {

...

Why did the comments get dropped?

dosen't list hw information in public

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 24 Dec 2019 06:58:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Chen Wisley (Code Review)

26 Dec 26 Dec

4:36 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37864/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/include/variant/sku.h:

https://review.coreboot.org/c/coreboot/+/37864/3/src/mainboard/google/hatch/... PS3, Line 19: enum {

...

dosen't list hw information in public

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 26 Dec 2019 15:36:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Chen Wisley wisley.chen@quantatw.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

27 Dec 27 Dec

9:58 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37864 )

Change subject: mb/google/hatch/var/dratini: Add a new sku for dragonair ......................................................................

mb/google/hatch/var/dratini: Add a new sku for dragonair

Add a new sku for dragonair

BUG=b:146504217 TEST=emerge-hatch coreboot

Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37864 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/dratini/include/variant/sku.h M src/mainboard/google/hatch/variants/dratini/variant.c 2 files changed, 5 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h b/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h index e36d335..a9a50e4 100644 --- a/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h +++ b/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h @@ -17,9 +17,10 @@ #define __MAINBOARD_SKU_H__

enum { - SKU_21_DRAGONAIR = 21, /* TS + FPS + Stylus */ - SKU_22_DRAGONAIR = 22, /* TS + KB_BL + FPS + Stylus */ - SKU_23_DRAGONAIR = 23, /* TS + Stylus */ + SKU_21_DRAGONAIR = 21, + SKU_22_DRAGONAIR = 22, + SKU_23_DRAGONAIR = 23, + SKU_24_DRAGONAIR = 24, };

-- To view, visit https://review.coreboot.org/c/coreboot/+/37864 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4492d65f35d3583df1606c5f2901228b3ae14e4a Gerrit-Change-Number: 37864 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1853

days inactive

1860

days old

coreboot-gerrit@coreboot.org

14 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Chen Wisley (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Tim Wawrzynczak (Code Review)