Change in coreboot[master]: soc/rockchip/rk3288/include/soc: Add missing include <stddef.h>
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34235 )
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <stddef.h> ......................................................................
soc/rockchip/rk3288/include/soc: Add missing include <stddef.h>
Change-Id: Ibde48d7cff582c91f55ad5f1328aac64d018b3c5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/rockchip/rk3288/include/soc/sdram.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/34235/1
diff --git a/src/soc/rockchip/rk3288/include/soc/sdram.h b/src/soc/rockchip/rk3288/include/soc/sdram.h index 5a26a0a..65d50a8 100644 --- a/src/soc/rockchip/rk3288/include/soc/sdram.h +++ b/src/soc/rockchip/rk3288/include/soc/sdram.h @@ -16,6 +16,8 @@ #ifndef __SOC_ROCKCHIP_RK3288_SDRAM_H__ #define __SOC_ROCKCHIP_RK3288_SDRAM_H__
+#include <stddef.h> + enum { DDR3 = 3, LPDDR3 = 6,
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34235 )
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <stddef.h> ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34235/1/src/soc/rockchip/rk3288/inc... File src/soc/rockchip/rk3288/include/soc/sdram.h:
https://review.coreboot.org/c/coreboot/+/34235/1/src/soc/rockchip/rk3288/inc... PS1, Line 99: size_t needs #include <stddef.h>
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34235 )
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <stddef.h> ......................................................................
Patch Set 1: Code-Review+2
nit: personally I prefer <types.h> for this, but I guess it's a matter of taste.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34235 )
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <stddef.h> ......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/34235/1/src/soc/rockchip/rk3288/inc... File src/soc/rockchip/rk3288/include/soc/sdram.h:
https://review.coreboot.org/c/coreboot/+/34235/1/src/soc/rockchip/rk3288/inc... PS1, Line 28: u8 Actually, all of these need <stdint.h> too. So why not just add <types.h> instead?
Hello Julius Werner, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34235
to look at the new patch set (#2).
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <stddef.h> ......................................................................
soc/rockchip/rk3288/include/soc: Add missing include <stddef.h>
Change-Id: Ibde48d7cff582c91f55ad5f1328aac64d018b3c5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/rockchip/rk3288/include/soc/sdram.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/34235/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34235 )
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <stddef.h> ......................................................................
Patch Set 2:
Thank you for the review.
Hello Julius Werner, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34235
to look at the new patch set (#3).
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <types.h> ......................................................................
soc/rockchip/rk3288/include/soc: Add missing include <types.h>
Change-Id: Ibde48d7cff582c91f55ad5f1328aac64d018b3c5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/rockchip/rk3288/include/soc/sdram.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/34235/3
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34235 )
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <types.h> ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34235 )
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <types.h> ......................................................................
soc/rockchip/rk3288/include/soc: Add missing include <types.h>
Change-Id: Ibde48d7cff582c91f55ad5f1328aac64d018b3c5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34235 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/rockchip/rk3288/include/soc/sdram.h 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/soc/rockchip/rk3288/include/soc/sdram.h b/src/soc/rockchip/rk3288/include/soc/sdram.h index 5a26a0a..3ad51b6 100644 --- a/src/soc/rockchip/rk3288/include/soc/sdram.h +++ b/src/soc/rockchip/rk3288/include/soc/sdram.h @@ -16,6 +16,8 @@ #ifndef __SOC_ROCKCHIP_RK3288_SDRAM_H__ #define __SOC_ROCKCHIP_RK3288_SDRAM_H__
+#include <types.h> + enum { DDR3 = 3, LPDDR3 = 6,
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)
-
Martin Roth (Code Review)