Attention is currently required from: Furquan Shaikh, Martin Roth, Duncan Laurie.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52747 )
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS3:
Please update Documentation/lib/fw_config. […]
Ack.
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/52747/comment/92ffc101_823ac185
PS3, Line 598: ((1ull << (1ull + bits->end_bit - bits->start_bit)) - 1ull);
could pull this into a function that takes fw_config_field_bits since it is used in multiple places […]
Done
File util/sconfig/sconfig.h:
https://review.coreboot.org/c/coreboot/+/52747/comment/a3fffaa3_eca8c48a
PS3, Line 230: append_bits
I would suggest adding fw_config in the name to match all the other fw_config callbacks. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ed76706347ee9642198efc77139abdc3af1b8a6
Gerrit-Change-Number: 52747
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
duncan@iceblink.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Duncan Laurie
duncan@iceblink.org
Gerrit-Comment-Date: Thu, 29 Apr 2021 20:01:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
duncan@iceblink.org
Gerrit-MessageType: comment