Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39357 )
Change subject: mb/google/volteer: Enable Xdci and Xhci for Volteer ......................................................................
mb/google/volteer: Enable Xdci and Xhci for Volteer
For TCSS to enable USB3 functionality the Xhci and Xdci Tcss flags need to be set in devicetree.
BUG=144874778 TEST=none
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/39357/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 65df68c..c93887f 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -121,6 +121,9 @@ # Not disconnected/enumerable register "PchHdaIDispCodecDisconnect" = "0"
+ # TCSS USB3 + register "TcssXhciEn" = "1" + # DP port register "DdiPortAConfig" = "1" # eDP register "DdiPortBConfig" = "0"
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39357 )
Change subject: mb/google/volteer: Enable Xdci and Xhci for Volteer ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39357/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39357/2//COMMIT_MSG@9 PS2, Line 9: Xdci Change does not really enabled Xdci.
Hello build bot (Jenkins), Brandon Breitenstein,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39357
to look at the new patch set (#3).
Change subject: mb/google/volteer: Enable Xdci and Xhci for Volteer ......................................................................
mb/google/volteer: Enable Xdci and Xhci for Volteer
For TCSS to enable USB3 functionality the Xhci and Xdci Tcss flags need to be set in devicetree.
BUG=144874778 TEST=Built with Volteer recipe and verified USB functionality
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/39357/3
Hello build bot (Jenkins), Brandon Breitenstein,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39357
to look at the new patch set (#5).
Change subject: mb/google/volteer: set Xdci and Xhci flags ......................................................................
mb/google/volteer: set Xdci and Xhci flags
For TCSS to enable USB3 functionality, the Xhci and Xdci Tcss flags need to be set in devicetree.
BUG=144874778 TEST=Built with Volteer recipe and verified USB functionality
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/39357/5
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39357 )
Change subject: mb/google/volteer: set Xdci and Xhci flags ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39357/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39357/2//COMMIT_MSG@9 PS2, Line 9: Xdci
Change does not really enabled Xdci.
Done
Hello build bot (Jenkins), Brandon Breitenstein,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39357
to look at the new patch set (#8).
Change subject: mb/google/volteer: set Xdci and Xhci flags ......................................................................
mb/google/volteer: set Xdci and Xhci flags
For TCSS to enable USB3 functionality, the Xhci and Xdci Tcss flags need to be set in devicetree.
BUG=144874778 TEST=Built with Volteer recipe and verified USB functionality
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/39357/8
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39357 )
Change subject: mb/google/volteer: set Xdci and Xhci flags ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39357/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39357/8//COMMIT_MSG@7 PS8, Line 7: Xdci Not true.
https://review.coreboot.org/c/coreboot/+/39357/8//COMMIT_MSG@9 PS8, Line 9: Xdci Not true.
Hello build bot (Jenkins), Brandon Breitenstein,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39357
to look at the new patch set (#9).
Change subject: mb/google/volteer: set TcssXhciEn to 1 ......................................................................
mb/google/volteer: set TcssXhciEn to 1
BUG=144874778 TEST=Built with Volteer recipe and verified USB functionality
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/39357/9
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39357 )
Change subject: mb/google/volteer: set TcssXhciEn to 1 ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39357/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39357/8//COMMIT_MSG@7 PS8, Line 7: Xdci
Not true.
Done
https://review.coreboot.org/c/coreboot/+/39357/8//COMMIT_MSG@9 PS8, Line 9: Xdci
Not true.
Done
Hello build bot (Jenkins), Brandon Breitenstein,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39357
to look at the new patch set (#10).
Change subject: mb/google/volteer: set TcssXhciEn to 1 ......................................................................
mb/google/volteer: set TcssXhciEn to 1
BUG=144874778 TEST=Built with Volteer recipe and verified USB functionality
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/39357/10
Hello build bot (Jenkins), Brandon Breitenstein,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39357
to look at the new patch set (#11).
Change subject: mb/google/volteer: set TcssXhciEn to 1 ......................................................................
mb/google/volteer: set TcssXhciEn to 1
BUG=144874778 TEST=Built with Volteer recipe and verified USB functionality
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/39357/11
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39357 )
Change subject: mb/google/volteer: set TcssXhciEn to 1 ......................................................................
Patch Set 11: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Brandon Breitenstein,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39357
to look at the new patch set (#13).
Change subject: mb/google/volteer: set TcssXhciEn to 1 ......................................................................
mb/google/volteer: set TcssXhciEn to 1
BUG=144874778 TEST=Built with Volteer recipe and verified USB functionality
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/39357/13
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39357 )
Change subject: mb/google/volteer: set TcssXhciEn to 1 ......................................................................
Patch Set 13: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39357 )
Change subject: mb/google/volteer: set TcssXhciEn to 1 ......................................................................
mb/google/volteer: set TcssXhciEn to 1
BUG=144874778 TEST=Built with Volteer recipe and verified USB functionality
Change-Id: I6cbdbd8a4f65a0fe19e3fb8d7b60b8b849f104e7 Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39357 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 070e4f6..dd6895b 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -110,6 +110,9 @@ [PchSerialIoIndexUART2] = PchSerialIoDisabled, }"
+ # TCSS USB3 + register "TcssXhciEn" = "1" + # DP port register "DdiPortAConfig" = "1" # eDP register "DdiPortBConfig" = "0"
-
Furquan Shaikh (Code Review) -
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)