Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 42:
(40 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/f6829c11_0f2dff85 PS42, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/a6265b2d_fe4fe29f PS42, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/4669c40a_ae03c894 PS42, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/e2391a25_fef3f1fe PS42, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/2d5bc9cd_67bbce41 PS42, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/c6d90a17_16506939 PS42, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/e9aa5440_910c14ef PS42, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/6bcca8ed_572e1bfa PS42, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/d74a748f_18cbad13 PS42, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/e5fffcc8_5b857cf4 PS42, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/3c54e6c8_6004385a PS42, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/eef20741_f23d22b1 PS42, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/761a4f9a_b76918f3 PS42, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/91ad60dc_6afc8c28 PS42, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/6beba241_3243ea3c PS42, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/3d13fd2e_22a1741d PS42, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/67b67ed0_61eb7596 PS42, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/ce0ed408_e668e155 PS42, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/622280be_098e78d3 PS42, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/7444f7d9_9e7b3153 PS42, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/822dc988_e8efdc1c PS42, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/a16cce31_f8c1b3a5 PS42, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/9c6b974c_03ebe096 PS42, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/23f7b3b5_9e054d72 PS42, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/b136c7a1_6cbf9801 PS42, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/f4210956_9d029564 PS42, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/ff010d0f_1f55639e PS42, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/d380c8cd_aeb95ab9 PS42, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/d70e5a10_6acb1985 PS42, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/8ce4d526_06c1182e PS42, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/7f0154be_ae2e9407 PS42, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/c958acf9_6b1214e4 PS42, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/ac361575_1a04f166 PS42, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/bf93f634_f0a13005 PS42, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/55d63b52_069bfdf7 PS42, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/b7446a95_c046768b PS42, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/bcb275a0_1b4b1ed0 PS42, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/a5df598e_08a6e7f4 PS42, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/7ea426c2_c3dbed07 PS42, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120394): https://review.coreboot.org/c/coreboot/+/49768/comment/58b885a9_0c180683 PS42, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)