Attention is currently required from: Star Labs, Andy Pont. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52797 )
Change subject: ec: Add Star Labs ITE 8987E support ......................................................................
Patch Set 7:
(2 comments)
File src/ec/starlabs/it8987/ec.h:
https://review.coreboot.org/c/coreboot/+/52797/comment/ae57c05f_13d4f557 PS6, Line 11: 0x4e
The datasheet for the IT8987 does allow 0x2e/0x2f and 0x4e/0x4f as address/data register pairs. […]
But it could be changed. See comment in source file.
File src/ec/starlabs/it8987/ec.c:
https://review.coreboot.org/c/coreboot/+/52797/comment/6f2028da_a735da12 PS7, Line 16: IT8987E_ADDR this address can be optioned from the struct device* passed in it8987_init. It's the address you assign to the PNP device in the mainboard's devicetree. There are also helper functions that allow to read the SIO address space, no need to open code it.
-
Patrick Rudolph (Code Review)