Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50178 )
Change subject: memory_info.h: Store SMBIOS error correction type
......................................................................
Patch Set 1:
(1 comment)
File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/50178/comment/37828f5a_e346804c
PS1, Line 103: uint8_t ecc_type;
This struct is a mess already as some types from SMBIOS are used while other fields have a custom en […]
The enum type is wider, though. Given that this struct is __packed, I didn't want to make it larger than it needs to be.
If size is no longer an issue, I agree that we should be using the SMBIOS types here. However, I'd rather make a follow-up patch to replace all at once. What do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I863f8e34c84841d931dfb8d7067af0f12a437e36
Gerrit-Change-Number: 50178
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 03 Feb 2021 10:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment