Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: [WIP]chromeos: share "EC in RW" GPIO with depthcharge ......................................................................
[WIP]chromeos: share "EC in RW" GPIO with depthcharge
BUG=None BRANCH=None TEST=Build and boot TGL RVP. Check recovery works with crossystem recovery_request.
Change-Id: I1e88200e3f8418e5b0ab39ac65ed1b3545ce111e Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/intel/tglrvp/chromeos.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40861/1
diff --git a/src/mainboard/intel/tglrvp/chromeos.c b/src/mainboard/intel/tglrvp/chromeos.c index c479c89..0d0d7be 100644 --- a/src/mainboard/intel/tglrvp/chromeos.c +++ b/src/mainboard/intel/tglrvp/chromeos.c @@ -13,6 +13,7 @@ {-1, ACTIVE_HIGH, get_lid_switch(), "lid"}, {-1, ACTIVE_HIGH, 0, "power"}, {-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"}, + {-1, ACTIVE_HIGH, 0, "EC in RW"}, }; lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); }
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: [WIP]chromeos: share "EC in RW" GPIO with depthcharge ......................................................................
Patch Set 1:
Below are also difference for both tglrvp and volteer {-1, ACTIVE_HIGH, get_write_protect_state(), "write protect"},
Hello build bot (Jenkins), Wonkyu Kim,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40861
to look at the new patch set (#2).
Change subject: [WIP]chromeos: Enable recovery in TGL RVP ......................................................................
[WIP]chromeos: Enable recovery in TGL RVP
Share "EC in RW" GPIO with depthcharge. Also we define the CONFIGS needed CHROME, CHROME_EC and use the chrome lid and recovery.
BUG=None BRANCH=None TEST=Build and boot TGL RVP. Check recovery works with crossystem recovery_request.
Change-Id: I1e88200e3f8418e5b0ab39ac65ed1b3545ce111e Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/chromeos.c 2 files changed, 8 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40861/2
Hello build bot (Jenkins), Wonkyu Kim,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40861
to look at the new patch set (#3).
Change subject: chromeos: Enable recovery in TGL RVP ......................................................................
chromeos: Enable recovery in TGL RVP
Share "EC in RW" GPIO with depthcharge. Also we define the CONFIGS needed CHROME, CHROME_EC and use the chrome lid and recovery.
BUG=None BRANCH=None TEST=Build and boot TGL RVP. Check recovery works with crossystem recovery_request.
Change-Id: I1e88200e3f8418e5b0ab39ac65ed1b3545ce111e Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/chromeos.c 2 files changed, 8 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40861/3
Hello build bot (Jenkins), Wonkyu Kim,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40861
to look at the new patch set (#4).
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
mb/intel/tglrvp: Enable recovery in TGL RVP
Share "EC in RW" GPIO with depthcharge. Also we define the CONFIGS needed CHROME, CHROME_EC and use the chrome lid and recovery.
BUG=None BRANCH=None TEST=Build and boot TGL RVP. Check recovery works with crossystem recovery_request.
Change-Id: I1e88200e3f8418e5b0ab39ac65ed1b3545ce111e Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/chromeos.c 2 files changed, 8 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40861/4
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40861/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40861/4//COMMIT_MSG@11 PS4, Line 11: and use the chrome lid and recovery. Please re-flow for 75 characters per line.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40861/4/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/40861/4/src/mainboard/intel/tglrvp/... PS4, Line 76: select GBB_FLAG_FORCE_DEV_SWITCH_ON : select GBB_FLAG_FORCE_DEV_BOOT_USB Can we also have these configs for Intel EC case? At least GBB_FLAG_FORCE_DEV_BOOT_USB should be set in Intel EC case.
https://review.coreboot.org/c/coreboot/+/40861/4/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/40861/4/src/mainboard/intel/tglrvp/... PS4, Line 19: int get_lid_switch(void) : { : /* Lid always open */ : return 1; : } : : int get_recovery_mode_switch(void) : { : return 0; : } Can you also check non Chrome EC case? As I remember, they're used for non Chrome EC case.
Hello build bot (Jenkins), Wonkyu Kim, Ravishankar Sarawadi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40861
to look at the new patch set (#5).
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
mb/intel/tglrvp: Enable recovery in TGL RVP
Share "EC in RW" GPIO with depthcharge. Also we define the CONFIGS needed CHROME, CHROME_EC and use the chrome lid and recovery.
BUG=None BRANCH=None TEST=Build and boot TGL RVP. Check recovery works with crossystem recovery_request.
Change-Id: I1e88200e3f8418e5b0ab39ac65ed1b3545ce111e Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/chromeos.c 2 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40861/5
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40861/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40861/4//COMMIT_MSG@11 PS4, Line 11: and use the chrome lid and recovery.
Please re-flow for 75 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/40861/4/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/40861/4/src/mainboard/intel/tglrvp/... PS4, Line 76: select GBB_FLAG_FORCE_DEV_SWITCH_ON : select GBB_FLAG_FORCE_DEV_BOOT_USB
Can we also have these configs for Intel EC case? […]
Done
https://review.coreboot.org/c/coreboot/+/40861/4/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/40861/4/src/mainboard/intel/tglrvp/... PS4, Line 19: int get_lid_switch(void) : { : /* Lid always open */ : return 1; : } : : int get_recovery_mode_switch(void) : { : return 0; : }
Can you also check non Chrome EC case? […]
Done
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 5: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40861/5/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/40861/5/src/mainboard/intel/tglrvp/... PS5, Line 23: select EC_GOOGLE_CHROMEEC_SWITCHES this should be moved under config TGL_CHROME_EC. With this change, TGL_INTEL_EC build is failed during make olddefconfig
ex) make distclean cp 3rdparty/blobs/files/configs/config.tglrvp_up3 .config echo "CONFIG_TGL_INTEL_EC=y" >> .config make olddefconfig
Hello build bot (Jenkins), Wonkyu Kim, Ravishankar Sarawadi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40861
to look at the new patch set (#6).
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
mb/intel/tglrvp: Enable recovery in TGL RVP
Share "EC in RW" GPIO with depthcharge. Also we define the CONFIGS needed CHROME, CHROME_EC and use the chrome lid and recovery.
BUG=None BRANCH=None TEST=Build and boot TGL RVP. Check recovery works with crossystem recovery_request.
Change-Id: I1e88200e3f8418e5b0ab39ac65ed1b3545ce111e Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/chromeos.c 2 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40861/6
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40861/5/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/40861/5/src/mainboard/intel/tglrvp/... PS5, Line 23: select EC_GOOGLE_CHROMEEC_SWITCHES
this should be moved under config TGL_CHROME_EC. […]
Done
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 6: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 6: Code-Review+2
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 6: Code-Review+2
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40861 )
Change subject: mb/intel/tglrvp: Enable recovery in TGL RVP ......................................................................
mb/intel/tglrvp: Enable recovery in TGL RVP
Share "EC in RW" GPIO with depthcharge. Also we define the CONFIGS needed CHROME, CHROME_EC and use the chrome lid and recovery.
BUG=None BRANCH=None TEST=Build and boot TGL RVP. Check recovery works with crossystem recovery_request.
Change-Id: I1e88200e3f8418e5b0ab39ac65ed1b3545ce111e Signed-off-by: Shaunak Saha shaunak.saha@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40861 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/chromeos.c 2 files changed, 10 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Shaunak Saha: Looks good to me, approved Srinidhi N Kaushik: Looks good to me, approved Wonkyu Kim: Looks good to me, approved
diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index cfebc6b..8277875 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -16,10 +16,15 @@ select SOC_INTEL_TIGERLAKE select INTEL_LPSS_UART_FOR_CONSOLE select DRIVERS_INTEL_ISH + select EC_ACPI
config CHROMEOS bool default y + select EC_GOOGLE_CHROMEEC_SWITCHES if TGL_CHROME_EC + select GBB_FLAG_FORCE_MANUAL_RECOVERY + select HAS_RECOVERY_MRC_CACHE + select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB
@@ -68,9 +73,9 @@ config TGL_CHROME_EC bool "Chrome EC" select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_LPC select EC_GOOGLE_CHROMEEC_ESPI select EC_GOOGLE_CHROMEEC_BOARDID - select EC_ACPI
config TGL_INTEL_EC bool "Intel EC" @@ -81,8 +86,6 @@ config VBOOT select VBOOT_LID_SWITCH select VBOOT_MOCK_SECDATA - select HAS_RECOVERY_MRC_CACHE - select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
config UART_FOR_CONSOLE int diff --git a/src/mainboard/intel/tglrvp/chromeos.c b/src/mainboard/intel/tglrvp/chromeos.c index 70a92f2..7da61be 100644 --- a/src/mainboard/intel/tglrvp/chromeos.c +++ b/src/mainboard/intel/tglrvp/chromeos.c @@ -12,10 +12,12 @@ {-1, ACTIVE_HIGH, get_lid_switch(), "lid"}, {-1, ACTIVE_HIGH, 0, "power"}, {-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"}, + {-1, ACTIVE_HIGH, 0, "EC in RW"}, }; lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); }
+#if !CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) int get_lid_switch(void) { /* Lid always open */ @@ -27,6 +29,8 @@ return 0; }
+#endif /*!CONFIG(EC_GOOGLE_CHROMEEC_SWITCHES) */ + int get_write_protect_state(void) { /* No write protect */
-
Patrick Georgi (Code Review) -
Paul Menzel (Code Review)
-
Shaunak Saha (Code Review)
-
Srinidhi N Kaushik (Code Review)
-
Wonkyu Kim (Code Review)