Attention is currently required from: Krishna Prabhakaran, Selma Bensaid, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1
......................................................................
Patch Set 8:
(2 comments)
File src/drivers/intel/gma/opregion.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123492):
https://review.coreboot.org/c/coreboot/+/52758/comment/d674f528_a83503ce
PS8, Line 278: /* Fill RVDA value with relative address of the opregion buffer in case of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123492):
https://review.coreboot.org/c/coreboot/+/52758/comment/b747a8be_495898cb
PS8, Line 281: if((CONFIG(INTEL_IGD_OPREGION_VERSION)) > 0x200)
space required before the open parenthesis '('
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b
Gerrit-Change-Number: 52758
Gerrit-PatchSet: 8
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 06 Jul 2021 09:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment