Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77092?usp=email )
Change subject: soc/amd/*: Fix UART ACPI device status
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
this will probably be the best approach that is both feasible and doesn't have significant side effects
File src/soc/amd/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/77092/comment/847d4963_c1a58045 :
PS2, Line 73:
i'd drop this empty line
File src/soc/amd/stoneyridge/acpi/mmio.asl:
PS2:
doesn't look like stoney is using amd_uart_mmio_ops. would still be good to leave a TODO in the stoney mmio.asl file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77092?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id89e74c3ea7f53280935898ee35311b7cf3b152a
Gerrit-Change-Number: 77092
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 08 Aug 2023 16:57:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment