Change in coreboot[master]: mb/google/brya: Add MEMORY_SODIMM and MEMORY_SOLDERDOWN config - coreboot-gerrit

19 Jan 2022


      Attention is currently required from: Tim Wawrzynczak, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61193 )
Change subject: mb/google/brya: Add MEMORY_SODIMM and MEMORY_SOLDERDOWN config
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/61193/comment/8c0bca9e_9003114b 
PS1, Line 216: config MEMORY_SODIMM
...
Do we need choice here?
this might help you to skip adding 'if' in line#43
...
You can't change it since it has been decided at first time.
I didn't get this part. Can you please help me to understand `what we can't change`
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61193
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idab48293fb5b584ecb4c8f270d2c376456954553
Gerrit-Change-Number: 61193
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 19 Jan 2022 08:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment