Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47314 )
Change subject: util/intelp2m: Cleanup SCI, SMI macro generation and update comments
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47314/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47314/4//COMMIT_MSG@7
PS4, Line 7: Cleanup
The verb is spelled with a space: Clean up.
https://review.coreboot.org/c/coreboot/+/47314/4//COMMIT_MSG@9
PS4, Line 9: fix-up
fix up
https://review.coreboot.org/c/coreboot/+/47314/4//COMMIT_MSG@10
PS4, Line 10: CB:45008
As git is operated using commit SHA’s, it’d be great if you could add that hash too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47314
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie49874d4abbdc7d1a18d63a62ccbce970ce78233
Gerrit-Change-Number: 47314
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Nov 2020 07:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment