Attention is currently required from: Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Subrata Banik.
Angel Pons has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email )
Change subject: soc/intel/cmn/pmc: Add support for early power off
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
AIUI, the problem here is that the PCH doesn't want to power off in early stages, so the workaround is to tell the EC (in this case, chromeec) to power off the platform instead
Commit Message:
https://review.coreboot.org/c/coreboot/+/86336/comment/5b60ff63_58eac637?usp... :
PS2, Line 10: alongwith
nit: along with
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86336?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I39f516640b3f75ab4c6a09826922289c0533f79b
Gerrit-Change-Number: 86336
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 10 Feb 2025 05:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No