Attention is currently required from: Raul Rangel, Jason Nien, Isaac Lee, Jon Murphy, Tim Wawrzynczak, Martin Roth, Eric Peers, Moises Garcia, Tim Van Patten, Karthikeyan Ramasubramanian.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68077 )
Change subject: mb/google/skyrim/var/winterhold: Expend EC share memory register define for Dynamic Thermal Table Switching Proposal
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68077/comment/9e242fb5_be3cf0a8
PS1, Line 6:
Subject line should not end with a period.
Please fix.
https://review.coreboot.org/c/coreboot/+/68077/comment/28026a5c_5973183a
PS1, Line 6:
Possible long commit subject (prefer a maximum 65 characters)
Please fix.
https://review.coreboot.org/c/coreboot/+/68077/comment/974dc6bc_d5d8c0d3
PS1, Line 10: Define offset 0x09 bit 5 for temperature status of thermal table switch
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37b3a0d8f6546361c8d5501e98e3e1b0d814fce3
Gerrit-Change-Number: 68077
Gerrit-PatchSet: 2
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Moises Garcia
moisesgarcia@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Moises Garcia
moisesgarcia@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Mon, 03 Oct 2022 08:35:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment