Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Hello Shuo Liu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/81134?usp=email
to review the following change.
Change subject: soc/intel/xeon_sp: Unshare SMM related Kconfigs ......................................................................
soc/intel/xeon_sp: Unshare SMM related Kconfigs
Allow for options that platform is with FSP based SMM handlers.
Change-Id: Icc5f71e44f573575d599d2617a037bfd14e79dec Signed-off-by: Shuo Liu shuo.liu@intel.com Signed-off-by: Jincheng Li jincheng.li@intel.com --- M src/soc/intel/xeon_sp/Kconfig M src/soc/intel/xeon_sp/cpx/Kconfig M src/soc/intel/xeon_sp/skx/Kconfig M src/soc/intel/xeon_sp/spr/Kconfig 4 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/81134/1
diff --git a/src/soc/intel/xeon_sp/Kconfig b/src/soc/intel/xeon_sp/Kconfig index 52aaec17..1e9cdd3 100644 --- a/src/soc/intel/xeon_sp/Kconfig +++ b/src/soc/intel/xeon_sp/Kconfig @@ -13,7 +13,6 @@ select FSP_M_XIP select FSP_PLATFORM_MEMORY_SETTINGS_VERSIONS select FSP_T_XIP - select HAVE_SMI_HANDLER select INTEL_CAR_NEM # For postcar only now select INTEL_DESCRIPTOR_MODE_CAPABLE select PARALLEL_MP_AP_WORK @@ -29,7 +28,6 @@ select SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT select SOC_INTEL_COMMON_BLOCK_GPIO_PADCFG_PADTOL select SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE - select SOC_INTEL_COMMON_BLOCK_SMM select SOC_INTEL_COMMON_BLOCK_TCO select SOC_INTEL_COMMON_PCH_SERVER select SUPPORT_CPU_UCODE_IN_CBFS diff --git a/src/soc/intel/xeon_sp/cpx/Kconfig b/src/soc/intel/xeon_sp/cpx/Kconfig index 51e545f..cd4fa3b 100644 --- a/src/soc/intel/xeon_sp/cpx/Kconfig +++ b/src/soc/intel/xeon_sp/cpx/Kconfig @@ -9,6 +9,8 @@ select HAVE_INTEL_FSP_REPO select FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND select UDK_202005_BINDING + select HAVE_SMI_HANDLER + select SOC_INTEL_COMMON_BLOCK_SMM help Intel Cooper Lake-SP support
diff --git a/src/soc/intel/xeon_sp/skx/Kconfig b/src/soc/intel/xeon_sp/skx/Kconfig index 4a9e683..3913568 100644 --- a/src/soc/intel/xeon_sp/skx/Kconfig +++ b/src/soc/intel/xeon_sp/skx/Kconfig @@ -6,6 +6,8 @@ select PLATFORM_USES_FSP2_0 select NO_FSP_TEMP_RAM_EXIT select UDK_202005_BINDING + select HAVE_SMI_HANDLER + select SOC_INTEL_COMMON_BLOCK_SMM help Intel Skylake-SP support
diff --git a/src/soc/intel/xeon_sp/spr/Kconfig b/src/soc/intel/xeon_sp/spr/Kconfig index 3c3c45a..6264c51 100644 --- a/src/soc/intel/xeon_sp/spr/Kconfig +++ b/src/soc/intel/xeon_sp/spr/Kconfig @@ -16,6 +16,8 @@ select FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND select UDK_202005_BINDING select SOC_INTEL_HAS_CXL + select HAVE_SMI_HANDLER + select SOC_INTEL_COMMON_BLOCK_SMM help Intel Sapphire Rapids-SP support