Change in coreboot[master]: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
verified by checking register dump: […]
``` com 2 root@debian:~# memtool md -l 0xfd6c0700+0x800 # GPD fd6c0700: 04000702 00003060 00000000 00000000 ....`0.......... fd6c0710: 04000702 00003c61 00000000 00000000 ....a<.......... fd6c0720: 04000102 00000062 00000000 00000000 ....b........... fd6c0730: 04000702 00003063 00000010 00000000 ....c0.......... fd6c0740: 04000600 00000064 00000000 00000000 ....d........... fd6c0750: 04000600 00000065 00000000 00000000 ....e........... fd6c0760: 44000700 00000066 00000000 00000000 ...Df........... fd6c0770: 04000201 00000067 00000000 00000000 ....g........... fd6c0780: 04000700 00000068 00000000 00000000 ....h........... fd6c0790: 04000200 00000069 00000000 00000000 ....i........... fd6c07a0: 44000500 0000306a 00000000 00000000 ...Dj0.......... fd6c07b0: 44000102 0000306b 00000000 00000000 ...Dk0.......... fd6c07c0: 00000700 00000000 00000000 00000000 ................ fd6c07d0: 00000700 00000000 00000000 00000000 ................ fd6c07e0: 00000700 00000000 00000000 00000000 ................ fd6c07f0: 00000702 00000000 00000000 00000000 ................ fd6c0800: 00000700 00000000 00000000 00000000 ................
fd6c0810: 00000000 00000000 00000000 00000000 ................ fd6c0820: 00000000 00000000 00000000 00000000 ................
com 4 root@debian:~# memtool md -l 0xfd6a0700+0x800 # GPP_C fd6a0700: 44000702 0003c06e 00000000 00000000 ...Dn........... fd6a0710: 44000702 0003c06f 00000000 00000000 ...Do........... fd6a0720: 44000201 00000070 00000100 00000000 ...Dp........... fd6a0730: 44000702 00000071 00000000 00000000 ...Dq........... fd6a0740: 44000702 00000072 00000000 00000000 ...Dr........... fd6a0750: 44000300 00000073 00000000 00000000 ...Ds........... fd6a0760: 04000702 00000074 00000000 00000000 ....t........... fd6a0770: 04000702 00000075 00000000 00000000 ....u........... fd6a0780: 44000300 00000076 00000000 00000000 ...Dv........... fd6a0790: 40100102 00003077 00000000 00000000 ...@w0.......... fd6a07a0: 44000300 00000018 00000000 00000000 ...D............ fd6a07b0: 44000300 00000019 00000000 00000000 ...D............ fd6a07c0: 44000300 0000001a 00000000 00000000 ...D............ fd6a07d0: 84000201 0000001b 00000000 00000000 ................ fd6a07e0: 44000300 0000101c 00000000 00000000 ...D............ fd6a07f0: 44000300 0000001d 00000000 00000000 ...D............ fd6a0800: 44000702 0000001e 00000000 00000000 ...D............ fd6a0810: 44000702 0000001f 00000000 00000000 ...D............ fd6a0820: 44000702 00000020 00000000 00000000 ...D ........... fd6a0830: 44000702 00000021 00000000 00000000 ...D!........... fd6a0840: 44000300 00000022 00000000 00000000 ...D"........... fd6a0850: 44000300 00000023 00000000 00000000 ...D#........... fd6a0860: 84000201 00000024 00000000 00000000 ....$........... fd6a0870: 40880102 00000025 00000000 00000000 ...@%........... # GPP_F fd6a0880: 44000700 00000056 00000100 00000000 ...DV........... fd6a0890: 44000702 00003057 00000100 00000000 ...DW0.......... fd6a08a0: 44000700 00000058 00000900 00000000 ...DX........... fd6a08b0: 44000702 00003059 00000100 00000000 ...DY0.......... fd6a08c0: 44000300 0000005a 00000100 00000000 ...DZ........... fd6a08d0: 44000300 0000005b 00000100 00000000 ...D[........... fd6a08e0: 44000300 0000005c 00000100 00000000 ...D........... fd6a08f0: 44000300 0000005d 00000000 00000000 ...D]........... fd6a0900: 44000300 0000005e 00000000 00000000 ...D^........... fd6a0910: 44000300 0000005f 00000000 00000000 ...D_........... fd6a0920: 44000300 00000060 00000000 00000000 ...D`........... fd6a0930: 44000300 00000061 00000000 00000000 ...Da........... fd6a0940: 44000300 00000062 00000000 00000000 ...Db........... fd6a0950: 44000300 00000063 00000000 00000000 ...Dc........... fd6a0960: 44000300 00000064 00000000 00000000 ...Dd........... fd6a0970: 44000300 00000065 00000000 00000000 ...De........... fd6a0980: 44000300 00000066 00000000 00000000 ...Df........... fd6a0990: 84000102 00000067 00000000 00000000 ....g........... fd6a09a0: 44000300 00000068 00000000 00000000 ...Dh........... fd6a09b0: 44000300 00000069 00000000 00000000 ...Di........... fd6a09c0: 44000300 0003c06a 00000000 00000000 ...Dj........... fd6a09d0: 44000100 0003d06b 00000000 00000000 ...Dk........... fd6a09e0: 44000300 0003c06c 00000000 00000000 ...Dl........... fd6a09f0: 44000300 0003c06d 00000000 00000000 ...Dm........... # GPPF_CLK_LOOPBK fd6a0a00: 40000f00 00000000 00000000 00000000 ...@............ ^^ # HVMOS fd6a0a10: 40000700 00000000 00000000 00000000 ...@............ fd6a0a20: 40000700 00000000 00000000 00000000 ...@............ fd6a0a30: 40000700 00000000 00000000 00000000 ...@............ fd6a0a40: 40000702 0003c000 00000000 00000000 ...@............ fd6a0a50: 40000702 0003c000 00000000 00000000 ...@............ fd6a0a60: 40000700 00000000 00000000 00000000 ...@............ ^^ # GPP_E fd6a0a70: 44000300 00000026 00000000 00000000 ...D&........... fd6a0a80: 84000200 00000027 00000000 00000000 ....'........... fd6a0a90: 44000300 00000028 00000000 00000000 ...D(........... fd6a0aa0: 44000102 00001029 00000000 00000000 ...D)........... fd6a0ab0: 44000300 00000030 00000000 00000000 ...D0........... fd6a0ac0: 44000300 00000031 00000000 00000000 ...D1........... fd6a0ad0: 44000300 00000032 00000800 00000000 ...D2........... fd6a0ae0: 44000300 00000033 00000000 00000000 ...D3........... fd6a0af0: 44000300 00000034 00000000 00000000 ...D4........... fd6a0b00: 44000300 00000035 00000800 00000000 ...D5........... fd6a0b10: 44000300 00000036 00000900 00000000 ...D6........... fd6a0b20: 44000300 00000037 00000900 00000000 ...D7........... fd6a0b30: 44000300 00000038 00000000 00000000 ...D8........... fd6a0b40: 44000300 00000039 00000000 00000000 ...D9........... fd6a0b50: 44000702 0002403a 00000000 00000000 ...D:@.......... fd6a0b60: 44000100 0000103b 00000000 00000000 ...D;........... fd6a0b70: 82840102 0000003c 00000000 00000000 ....<........... fd6a0b80: 44000300 0000003d 00000000 00000000 ...D=........... fd6a0b90: 44000300 00003c3e 00000000 00000000 ...D><.......... fd6a0ba0: 44000300 00003c3f 00000000 00000000 ...D?<.......... fd6a0bb0: 40880102 00000040 00000000 00000000 ...@@........... fd6a0bc0: 44000300 00000041 00000000 00000000 ...DA........... fd6a0bd0: 44000300 00000042 00000000 00000000 ...DB........... fd6a0be0: 44000300 00000043 00000000 00000000 ...DC........... # GPPE_CLK_LOOPBK fd6a0bf0: 40000700 00000000 00000100 00000000 ...@............ ^^ # JTAG fd6a0c00: 40000702 00003c00 00000000 00000000 ...@.<.......... fd6a0c10: 40000700 0003fc00 00000000 00000000 ...@............ fd6a0c20: 40000700 0003fc00 00000000 00000000 ...@............ fd6a0c30: 40000702 0003fc00 00000000 00000000 ...@............ fd6a0c40: 40000700 0003fc00 00000000 00000000 ...@............ fd6a0c50: 40000702 00003c00 00000000 00000000 ...@.<.......... fd6a0c60: 40000702 00003c00 00000000 00000000 ...@.<.......... fd6a0c70: 40000700 00003c00 00000000 00000000 ...@.<.......... fd6a0c80: 40000700 00003c00 00000800 00000000 ...@.<..........
fd6a0c90: 00000000 00000000 00000000 00000000 ................ fd6a0ca0: 00000000 00000000 00000000 00000000 ................ fd6a0cb0: 00000000 00000000 00000000 00000000 ................ fd6a0cc0: 00000000 00000000 00000000 00000000 ................ fd6a0cd0: 00000000 00000000 00000000 00000000 ................
com5 root@debian:~# memtool md -l 0xfd690700+0x800 # GPP_R fd690700: 44000700 0003c058 00000000 00000000 ...DX........... fd690710: 44000700 0003fc59 00000000 00000000 ...DY........... fd690720: 44000600 0003fc5a 00000000 00000000 ...DZ........... fd690730: 44000700 0003fc5b 00000000 00000000 ...D[........... fd690740: 44000700 0003c05c 00000000 00000000 ...D........... fd690750: 44000300 0000005d 00000000 00000000 ...D]........... fd690760: 44000300 0000005e 00000000 00000000 ...D^........... fd690770: 44000300 0000005f 00000000 00000000 ...D_...........
fd690780: 40000700 0003fc00 00000800 00000000 ...@............ ^^ # SPI fd690790: 40000700 0003fc00 00000800 00000000 ...@............ fd6907a0: 40000700 0003fc00 00000800 00000000 ...@............ fd6907b0: 40000700 0003fc00 00000000 00000000 ...@............ fd6907c0: 40000700 0003fc00 00000000 00000000 ...@............ fd6907d0: 40000700 0003fc00 00000000 00000000 ...@............ fd6907e0: 40000700 0003fc00 00000000 00000000 ...@............ fd6907f0: 40000700 0003fc00 00000000 00000000 ...@............ fd690800: 40000700 00000000 00000000 00000000 ...@............
fd690810: 00000000 00000000 00000000 00000000 ................ fd690820: 00000000 00000000 00000000 00000000 ................ fd690830: 00000000 00000000 00000000 00000000 ................ ```
-
Michael Niewöhner (Code Review)