Attention is currently required from: Tim Wawrzynczak, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50442 )
Change subject: drivers/i2c/hid: Enforce level triggered IRQ mode ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/hid/hid.c:
https://review.coreboot.org/c/coreboot/+/50442/comment/ffa22d61_94426fa3 PS2, Line 79: dev->enabled = 0;
I can update the IRQ mode to use LEVEL triggered with a warning. But if the HID device is not really following the specification, won't updating the IRQ mode mask the issue and lead to undefined behavior until someone notices the warning?
That is true. Setting enabled to 0 does force the user to pay attention to the error in BIOS logs. Before we do that, we should ensure that all the current users of i2c/hid driver are actually setting the irq line to level triggered.
-
Furquan Shaikh (Code Review)