Change in coreboot[master]: superio/common: Fix NULL pointer dereferences

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

John Zhao (Code Review)

23 Sep 2020 23 Sep '20

12:02 a.m.

John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45627 )

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

superio/common: Fix NULL pointer dereferences

Coverity detects the dev->link_list NULL pointer dereferences while calling report_resource_stored. Add sanity check for dev->link_list to prevent NULL pointer dereference.

Found-by: Coverity CID 1419488 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 --- M src/superio/common/generic.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45627/1

diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index 83f2fea..50db688 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -20,7 +20,8 @@ continue;

res->flags |= IORESOURCE_STORED; - report_resource_stored(dev, res, ""); + if (dev->link_list) + report_resource_stored(dev, res, ""); } }

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Angel Pons (Code Review)

23 Sep 23 Sep

12:35 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45627 )

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45627/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45627/1//COMMIT_MSG@11 PS1, Line 11: prevent NULL pointer dereference. Why not add the check inside `report_resource_stored`, then?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Gerrit-Change-Number: 45627 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Sep 2020 22:35:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Zhao (Code Review)

2:12 a.m.

Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45627

to look at the new patch set (#2).

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

superio/common: Fix NULL pointer dereferences

Coverity detects the dev->link_list NULL pointer dereferences while calling report_resource_stored. Add sanity check for dev->link_list to prevent NULL pointer dereference.

Found-by: Coverity CID 1419488 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 --- M src/device/device_util.c 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45627/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Gerrit-Change-Number: 45627 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

John Zhao (Code Review)

2:12 a.m.

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45627 )

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45627/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45627/1//COMMIT_MSG@11 PS1, Line 11: prevent NULL pointer dereference.

...

Why not add the check inside `report_resource_stored`, then?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/45627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Gerrit-Change-Number: 45627 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 23 Sep 2020 00:12:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

1:46 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45627 )

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/45627/2/src/device/device_util.c File src/device/device_util.c:

https://review.coreboot.org/c/coreboot/+/45627/2/src/device/device_util.c@52... PS2, Line 525: if (resource->flags & IORESOURCE_PCI_BRIDGE) { I'd place the check here:

if (dev->link_list && (resource->flags & IORESOURCE_PCI_BRIDGE)) {

This way, we still print the other information.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Gerrit-Change-Number: 45627 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 23 Sep 2020 11:46:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

John Zhao (Code Review)

8:10 p.m.

Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45627

to look at the new patch set (#3).

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

superio/common: Fix NULL pointer dereferences

Coverity detects the dev->link_list NULL pointer dereferences while calling report_resource_stored. Add sanity check for dev->link_list to prevent NULL pointer dereference.

Found-by: Coverity CID 1419488 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 --- M src/device/device_util.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/45627/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/45627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Gerrit-Change-Number: 45627 Gerrit-PatchSet: 3 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

John Zhao (Code Review)

8:12 p.m.

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45627 )

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45627/2/src/device/device_util.c File src/device/device_util.c:

https://review.coreboot.org/c/coreboot/+/45627/2/src/device/device_util.c@52... PS2, Line 525: if (resource->flags & IORESOURCE_PCI_BRIDGE) {

...

I'd place the check here: […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/45627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Gerrit-Change-Number: 45627 Gerrit-PatchSet: 3 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 23 Sep 2020 18:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

9:44 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45627 )

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Gerrit-Change-Number: 45627 Gerrit-PatchSet: 3 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 23 Sep 2020 19:44:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

28 Sep 28 Sep

11:31 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45627 )

Change subject: superio/common: Fix NULL pointer dereferences ......................................................................

superio/common: Fix NULL pointer dereferences

Coverity detects the dev->link_list NULL pointer dereferences while calling report_resource_stored. Add sanity check for dev->link_list to prevent NULL pointer dereference.

Found-by: Coverity CID 1419488 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45627 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/device/device_util.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/device/device_util.c b/src/device/device_util.c index 22c3db1..452a87b 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -519,7 +519,7 @@ end = resource_end(resource); buf[0] = '\0';

- if (resource->flags & IORESOURCE_PCI_BRIDGE) { + if (dev->link_list && (resource->flags & IORESOURCE_PCI_BRIDGE)) { snprintf(buf, sizeof(buf), "bus %02x ", dev->link_list->secondary); }

-- To view, visit https://review.coreboot.org/c/coreboot/+/45627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705 Gerrit-Change-Number: 45627 Gerrit-PatchSet: 4 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1677

days inactive

1683

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
John Zhao (Code Review)
Patrick Georgi (Code Review)