Change in coreboot[master]: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size

[Felix Held (Code Review)]

Attention is currently required from: Furquan Shaikh, Marshall Dawson, Meera Ravindranath, Andrey Petrov, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50241 )

Change subject: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size
......................................................................

Patch Set 1:

(1 comment)

File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/c/coreboot/+/50241/comment/1388675f_78bfdc52 
PS1, Line 242: !=
> What about <= instead of !=?  Assuming UPD only grows at the end, that would allow flexibility to up […]

you mean >, since <= would be break the good case as well? if hdr->cfg_region_size is bigger than sizeof(FSPM_UPD) it's a non-recoverable error and we should call die(), but doing a printk(BIOS_ERR, ...) in the hdr->cfg_region_size < sizeof(FSPM_UPD) case, but continuing would be an option