Attention is currently required from: Angel Pons, Arthur Heymans, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64341 )
Change subject: cpu/x86/mp_init.c: Use existing code to create cpu struct device
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS5:
If a CPU device exists but isn't enabled, using `add_cpu_device()` will enable it. Is this a problem?
Only if someone added them to the devicetree, which is not the case. https://review.coreboot.org/c/coreboot/+/68892/4 fixes that btw.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80baadd405b31d6be2fdbb894b0f4b7c775da6f8
Gerrit-Change-Number: 64341
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 19:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment