[M] Change in coreboot[master]: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table
Attention is currently required from: Subrata Banik.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 )
Change subject: soc/intel/cmn/block: Store CSE and ISHC version into cbmem table ......................................................................
Patch Set 5:
(14 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74208/comment/6a02a975_99ef463d PS2, Line 206: /*compare if stored cse version is same as current cse*/
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/e67f9b53_9eeca7d0 PS2, Line 208: struct fw_version_resp resp;
add this comment as line #208 […]
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/482fe199_c564d03c PS2, Line 210: */
one space to end the line
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/c018fca6_3c2418ef PS2, Line 210: /*
one space to start the line
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/e0e5b246_8bc9d06d PS2, Line 224: /*update current cse version*/
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/91c4fcf3_c77b21b2 PS2, Line 254: store_cse_version(&(cse_bp->fw_ver));
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/2ce0416a_09bc10e7 PS2, Line 1182: store_ishc_version();
Ack
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74208/comment/59fcbc42_25e7b85e PS4, Line 219: u
start with caps
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/9c8d63ff_21459d9f PS4, Line 219: u
start with caps
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/219cfa84_b9355c97 PS4, Line 229: live_cse
very innovative variable name, bt can u rename to make it more meaningful
Ack
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/74208/comment/da353ca2_114ac2e5 PS2, Line 147: pre_cse
prev_cse_fw_version
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/dc2ac7d6_5491fce2 PS2, Line 148: curr_ish
cur_ish_fw_version
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/6971b41f_9f98b5ca PS2, Line 153: curr_cse
cur_cse_fw_version
Ack
https://review.coreboot.org/c/coreboot/+/74208/comment/f4656220_aabd1763 PS2, Line 154: ish_info
ish_partition_info
Ack
-
Dinesh Gehlot (Code Review)