Change in coreboot[master]: arch/cpu/x86: Update AMD detection

[Marshall Dawson (Code Review)]

Hello Martin Roth,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/34146

to review the following change.

Change subject: arch/cpu/x86: Update AMD detection
......................................................................

arch/cpu/x86: Update AMD detection

AMD Picasso, and later, will not use CPU_AMD_AGESA or CPU_AMD_PI.
Those two symbols indicate an Arch2008 system.  Add SOC_AMD_COMMON
to cause cpu_is_amd() to return TRUE on Picasso.

This removes an error message of "Unknown CPU".

Signed-off-by: Marshall Dawson 
Change-Id: I3357606c37082f3587ff91924bf7a0e0f8af9625
---
M src/arch/x86/include/arch/cpu.h
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/34146/1

diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h
index 38066c1..e360dd6 100644
--- a/src/arch/x86/include/arch/cpu.h
+++ b/src/arch/x86/include/arch/cpu.h
@@ -210,7 +210,8 @@

static inline bool cpu_is_amd(void)
 {
-	return CONFIG(CPU_AMD_AGESA) || CONFIG(CPU_AMD_PI);
+	return CONFIG(CPU_AMD_AGESA) || CONFIG(CPU_AMD_PI)
+					|| CONFIG(SOC_AMD_COMMON);
 }

static inline bool cpu_is_intel(void)

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34146 )

Change subject: arch/cpu/x86: Update AMD detection
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34146/1/src/arch/x86/include/arch/c... 
File src/arch/x86/include/arch/cpu.h:

https://review.coreboot.org/c/coreboot/+/34146/1/src/arch/x86/include/arch/c... 
PS1, Line 214: 					|| CONFIG(SOC_AMD_COMMON);
CPU_AMD_MODEL_10XXX also missing?

[Marshall Dawson (Code Review)]

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34146

to look at the new patch set (#2).

Change subject: arch/cpu/x86: Update AMD detection
......................................................................

arch/cpu/x86: Update AMD detection

AMD Picasso, and later, will not use CPU_AMD_AGESA or CPU_AMD_PI.
Those two symbols indicate an Arch2008 system.  Add SOC_AMD_COMMON
to cause cpu_is_amd() to return TRUE on Picasso.

This removes an error message of "Unknown CPU".

The patch also assumes AMD Family 10h and non-AGESA Family 15h
devices were seeing the "Unknown CPU" message.  No functionality
has been verified on these devices.

Signed-off-by: Marshall Dawson 
Change-Id: I3357606c37082f3587ff91924bf7a0e0f8af9625
---
M src/arch/x86/include/arch/cpu.h
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/34146/2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34146 )

Change subject: arch/cpu/x86: Update AMD detection
......................................................................

Patch Set 2: Code-Review+2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34146 )

Change subject: arch/cpu/x86: Update AMD detection
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34146/1/src/arch/x86/include/arch/c... 
File src/arch/x86/include/arch/cpu.h:

https://review.coreboot.org/c/coreboot/+/34146/1/src/arch/x86/include/arch/c... 
PS1, Line 214: 					|| CONFIG(SOC_AMD_COMMON);
> CPU_AMD_MODEL_10XXX also missing?

Was wondering about the older ones, and whether they were improperly detected too...

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34146 )

Change subject: arch/cpu/x86: Update AMD detection
......................................................................

arch/cpu/x86: Update AMD detection

AMD Picasso, and later, will not use CPU_AMD_AGESA or CPU_AMD_PI.
Those two symbols indicate an Arch2008 system.  Add SOC_AMD_COMMON
to cause cpu_is_amd() to return TRUE on Picasso.

This removes an error message of "Unknown CPU".

The patch also assumes AMD Family 10h and non-AGESA Family 15h
devices were seeing the "Unknown CPU" message.  No functionality
has been verified on these devices.

Signed-off-by: Marshall Dawson 
Change-Id: I3357606c37082f3587ff91924bf7a0e0f8af9625
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34146
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/arch/x86/include/arch/cpu.h
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h
index 38066c1..32717ba 100644
--- a/src/arch/x86/include/arch/cpu.h
+++ b/src/arch/x86/include/arch/cpu.h
@@ -210,7 +210,8 @@

static inline bool cpu_is_amd(void)
 {
-	return CONFIG(CPU_AMD_AGESA) || CONFIG(CPU_AMD_PI);
+	return CONFIG(CPU_AMD_AGESA) || CONFIG(CPU_AMD_PI)
+			|| CONFIG(SOC_AMD_COMMON) || CONFIG(CPU_AMD_MODEL_10XXX);
 }

static inline bool cpu_is_intel(void)