Attention is currently required from: Wilson Chou, Marc Jones, Nico Huber, Ryback Hung, Johnny Lin, Tim Wawrzynczak, Shuming Chu (Shuming).
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67264 )
Change subject: src/device: Clear lane error status
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Based on where Wilson has put the call to clear_lane_error_status(), I am guessing that it is the li […]
We need to clear lane error status after (last) link training triggered by coreboot. Otherwise lspci would show (erroneous) lane error when booted from coreboot.
This issue was surfaced on xeon-sp server. We do not know whether it applies to other mainboard, hence added a Kconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67264
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6344223636409d8fc25e365a6375fc81e69f41a5
Gerrit-Change-Number: 67264
Gerrit-PatchSet: 2
Gerrit-Owner: Wilson Chou
wilson.chou%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Ryback Hung
ryback.hung@quantatw.com
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Wilson Chou
wilson.chou%quantatw.com@gtempaccount.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Ryback Hung
ryback.hung@quantatw.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Comment-Date: Thu, 01 Sep 2022 15:51:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment