Attention is currently required from: Gaggery Tsai, Lance Zhao, Martin L Roth, Paul Menzel, Subrata Banik, Tim Wawrzynczak.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77253?usp=email )
Change subject: src/acpi: Add BDAT support in ACPI
......................................................................
Patch Set 7:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/77253/comment/f09112ab_c1b009cb :
PS7, Line 1076: acpi_soc_get_bdat_region
This function is defined in another CL. I would recommend to squash both the patches together for build completeness. Otherwise merging this CL alone will break the coreboot build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77253?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ac6de9c97e98ee409ae1d872e3554bcc53aaf42
Gerrit-Change-Number: 77253
Gerrit-PatchSet: 7
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 18 Sep 2023 15:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment