[M] Change in coreboot[master]: util/amdfwtool/amdfwread: Update relative_offset function
Attention is currently required from: Raul Rangel, Rob Barnes, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66572 )
Change subject: util/amdfwtool/amdfwread: Update relative_offset function ......................................................................
Patch Set 6:
(3 comments)
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/66572/comment/13f30bad_f514fa43 PS5, Line 32: AMD_ADDR_PHYSICAL
Should we check if the physical address is pointing below the 16M SPI mapped region?
We have to hard-code 0xFF000000 as the base of the flashrom location. Or we can hard-code the base address of flashrom for each AMD SoC. I am not sure how quickly that will fall apart.
https://review.coreboot.org/c/coreboot/+/66572/comment/4a826cf8_123407f9 PS5, Line 40: exit
Print an error saying the mode is unknown
Done
https://review.coreboot.org/c/coreboot/+/66572/comment/923d4614_28abd360 PS5, Line 43: return ~(0UL);
I think you can omit this now that you have the `default` case exiting.
Done
-
Karthik Ramasubramanian (Code Review)