Attention is currently required from: Matt DeVillier, Nico Huber.
Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors and further options ......................................................................
Patch Set 4:
(1 comment)
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81426/comment/b6937413_e122828a : PS1, Line 369: #endif
Done
Unfortunately GCC will cry about the loop condition here
error: comparison of unsigned expression in '< 0' is always false [-Werror=type-limits]
I added pragmas to disable the warning as I couldn't find an obvious leaner local solution.
One could keep the #if here but then you have an unused symbol which would either require a pragma or C23 [[maybe_unused]]. GCC/Clang have __maybe_unused, would that be practical?
-
Joel Linn (Code Review)