Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49929 )
Change subject: soc/amd/cezanne: Enable early LPC support in bootblock stage
......................................................................
Patch Set 10:
(3 comments)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/49929/comment/7ad36335_babad728
PS5, Line 27: select SOC_AMD_COMMON_BLOCK_LPC
move this 2 lines up so it's in alphabetical order
Done
File src/soc/amd/cezanne/include/soc/acpi.h:
https://review.coreboot.org/c/coreboot/+/49929/comment/3d1f7b50_f67d0839
PS5, Line 7: PICASSO
CEZANNE
Done
File src/soc/amd/cezanne/include/soc/southbridge.h:
https://review.coreboot.org/c/coreboot/+/49929/comment/6a6fe40c_f1798a71
PS5, Line 13: PM_SERIRQ_NUM_BITS
Can you define a PM_SERIRQ_NUM_BITS_SHIFT and update all the BITS_X to have a value of 0-15
Keeping for now since it matches picasso.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I739d97ddc5afd84a4bbc7e505b423158eb820767
Gerrit-Change-Number: 49929
Gerrit-PatchSet: 10
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 08 Feb 2021 20:05:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment