Attention is currently required from: Julius Werner, Jacob Garber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50480 )
Change subject: drivers/spi: Stop using a variable-length array
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/50480/comment/85b59368_514e7bb6
PS1, Line 95: u8 buff[4 + (1 << DEFAULT_PAGE_SIZE_SHIFT)];
Hmmm... The problem is that we need to concatenate two buffers. […]
I made CB:50519 to avoid having to concatenate buffers inside this function. I'm not sure if it's an improvement, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib630bff1b496bc276616989d4506a3c96f242e26
Gerrit-Change-Number: 50480
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Comment-Date: Thu, 11 Feb 2021 11:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment