Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69094 )
Change subject: mb/google/brask/variants/moli: remove fan setting ......................................................................
mb/google/brask/variants/moli: remove fan setting
Disable Active Policy and remove fan setting to let ec control fan indenpendently.
BUG=b:236294162 TEST=emerge-brask coreboot
Signed-off-by: Raihow Shi raihow_shi@wistron.corp-partner.google.com Change-Id: Ie8851800d30ebf4d948d6eaadda2387c8afe52d8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69094 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Zhuohao Lee zhuohao@google.com Reviewed-by: Tarun Tuli taruntuli@google.com --- M src/mainboard/google/brya/variants/moli/overridetree.cb 1 file changed, 21 insertions(+), 30 deletions(-)
Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, approved Raihow Shi: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved Tarun Tuli: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/moli/overridetree.cb b/src/mainboard/google/brya/variants/moli/overridetree.cb index 2d35e14..8f1bf8e 100644 --- a/src/mainboard/google/brya/variants/moli/overridetree.cb +++ b/src/mainboard/google/brya/variants/moli/overridetree.cb @@ -48,18 +48,6 @@ register "options.tsr[1].desc" = ""CPU_VR"" register "options.tsr[2].desc" = ""DIMM""
- # TODO: below values are initial reference values only - ## Active Policy - register "policies.active" = "{ - [0] = { - .target = DPTF_CPU, - .thresholds = { - TEMP_PCT(85, 90), - TEMP_PCT(80, 80), - TEMP_PCT(75, 70), - } - } - }"
## Passive Policy register "policies.passive" = "{ @@ -98,24 +86,6 @@ [0] = 0x1 }"
- ## Fan Performance Control (Percent, Speed, Noise, Power) - register "controls.fan_perf" = "{ - [0] = { 90, 6700, 220, 2200, }, - [1] = { 80, 5800, 180, 1800, }, - [2] = { 70, 5000, 145, 1450, }, - [3] = { 60, 4900, 115, 1150, }, - [4] = { 50, 3838, 90, 900, }, - [5] = { 40, 2904, 55, 550, }, - [6] = { 30, 2337, 30, 300, }, - [7] = { 20, 1608, 15, 150, }, - [8] = { 10, 800, 10, 100, }, - [9] = { 0, 0, 0, 50, } - }" - - ## Fan options - register "options.fan.fine_grained_control" = "1" - register "options.fan.step_size" = "2" - device generic 0 alias dptf_policy on end end end