Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31367
Change subject: util/lint: Exclude util/inteltool from checkpatch ......................................................................
util/lint: Exclude util/inteltool from checkpatch
It's causing too much noise during review of register tables.
Change-Id: Iae6cd4454c5ed84b5fe0ea5f8a244e2a2fa13407 Signed-off-by: Nico Huber nico.huber@secunet.com --- M util/lint/lint-007-checkpatch 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/31367/1
diff --git a/util/lint/lint-007-checkpatch b/util/lint/lint-007-checkpatch index abc63f1..afa593e 100755 --- a/util/lint/lint-007-checkpatch +++ b/util/lint/lint-007-checkpatch @@ -22,6 +22,7 @@ EXCLUDED_DIRS="^payloads/libpayload/util/kconfig|\ ^payloads/libpayload/curses/PDCurses|\ ^util/crossgcc/patches|\ +^util/inteltool|\ ^util/kconfig|\ ^util/superiotool|\ ^src/vendorcode|\
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31367 )
Change subject: util/lint: Exclude util/inteltool from checkpatch ......................................................................
Patch Set 1: Code-Review+1
Is it only about the line length? Could this warning be selectively disabled?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31367 )
Change subject: util/lint: Exclude util/inteltool from checkpatch ......................................................................
Patch Set 1:
Is it only about the line length? Could this warning be selectively disabled?
It makes carefully hand-aligned tables a pain to review, e.g. https://review.coreboot.org/#/c/coreboot/+/29897/4/util/inteltool/gpio_group...
I guess you could calm the line-length warning plus make the lines longer so you can always use tabs, etc. But that might make the table harder to review, too.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31367 )
Change subject: util/lint: Exclude util/inteltool from checkpatch ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31367 )
Change subject: util/lint: Exclude util/inteltool from checkpatch ......................................................................
util/lint: Exclude util/inteltool from checkpatch
It's causing too much noise during review of register tables.
Change-Id: Iae6cd4454c5ed84b5fe0ea5f8a244e2a2fa13407 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/31367 Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/lint/lint-007-checkpatch 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Patrick Rudolph: Looks good to me, approved
diff --git a/util/lint/lint-007-checkpatch b/util/lint/lint-007-checkpatch index abc63f1..afa593e 100755 --- a/util/lint/lint-007-checkpatch +++ b/util/lint/lint-007-checkpatch @@ -22,6 +22,7 @@ EXCLUDED_DIRS="^payloads/libpayload/util/kconfig|\ ^payloads/libpayload/curses/PDCurses|\ ^util/crossgcc/patches|\ +^util/inteltool|\ ^util/kconfig|\ ^util/superiotool|\ ^src/vendorcode|\
-
Nico Huber (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)