Attention is currently required from: Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Paul Menzel, Balaji Manigandan, Bernardo Perez Priego, Tim Wawrzynczak.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58202 )
Change subject: mb/intel/adlrvp: Use dedicated VBT files for ADL-M
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58202/comment/2c17829b_36bf4945
PS3, Line 12: VBT files added at chrome-internal:4138272
These VBT are HW specific, not sure what is the advantage of making them public. […]
The advantage is that a single tree can build everything. The project's culture is "open, except ..." and so far I haven't heard of VBTs needing an exception.
That said, I don't intend to block this change over it, VBTs are just some thing that nobody ever could argue why they should be put under lock & wrap, but for some reason often are.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58202
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbf3f11c9277f5dcb3e12f9020f54ec843444c3f
Gerrit-Change-Number: 58202
Gerrit-PatchSet: 3
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 22:25:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Selma Bensaid
selma.bensaid@intel.com
Gerrit-MessageType: comment