EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40644 )
Change subject: mb/google/deltaur: Chane H1 I2C speed to STANDARD ......................................................................
mb/google/deltaur: Chane H1 I2C speed to STANDARD
Deltaur not tuned I2C speed for now. Slow down the H1 I2C to avoid I2C error for short term.
BUG=b:154310066 TEST=Check H1 has no I2C error occurs and can update by gsctool.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I85a63c1ab9a51d254873377a36d56823af11f0a9 --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/40644/1
diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index e0b3d50..498266e 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -92,7 +92,7 @@ .speed = I2C_SPEED_FAST, }, .i2c[3] = { - .speed = I2C_SPEED_FAST, + .speed = I2C_SPEED_STANDARD, .early_init = 1, }, .i2c[5] = {
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40644 )
Change subject: mb/google/deltaur: Chane H1 I2C speed to STANDARD ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG@7 PS1, Line 7: Chane Change
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG@9 PS1, Line 9: Deltaur not tuned I2C speed for now. Currently, Deltaur’s I2C speed has not been tuned yet, so slow …
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG@10 PS1, Line 10: I2C error for short term. Please paste the error, you got in the console.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40644 )
Change subject: mb/google/deltaur: Chane H1 I2C speed to STANDARD ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG@13 PS1, Line 13: TEST=Check H1 has no I2C error occurs and can update by gsctool. 1. occurring 2. … can be updated by …
Hello build bot (Jenkins), Tim Wawrzynczak, Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40644
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Change H1 I2C speed to STANDARD ......................................................................
mb/google/deltaur: Change H1 I2C speed to STANDARD
Currently, Deltaur’s I2C speed has not been tuned yet, so slow down the H1 I2C to avoid I2C error for short term.
Error logs: Reading cr50 TPM mode I2C receive timeout I2C read failed: bus 3 addr 0x50
BUG=b:154310066 TEST=Check H1 has no I2C error occurring and can be updated by gsctool.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I85a63c1ab9a51d254873377a36d56823af11f0a9 --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/40644/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40644 )
Change subject: mb/google/deltaur: Change H1 I2C speed to STANDARD ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG@7 PS1, Line 7: Chane
Change
Done
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG@9 PS1, Line 9: Deltaur not tuned I2C speed for now.
Currently, Deltaur’s I2C speed has not been tuned yet, so slow …
Done
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG@10 PS1, Line 10: I2C error for short term.
Please paste the error, you got in the console.
Done
https://review.coreboot.org/c/coreboot/+/40644/1//COMMIT_MSG@13 PS1, Line 13: TEST=Check H1 has no I2C error occurs and can update by gsctool.
- occurring […]
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40644 )
Change subject: mb/google/deltaur: Change H1 I2C speed to STANDARD ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40644 )
Change subject: mb/google/deltaur: Change H1 I2C speed to STANDARD ......................................................................
mb/google/deltaur: Change H1 I2C speed to STANDARD
Currently, Deltaur’s I2C speed has not been tuned yet, so slow down the H1 I2C to avoid I2C error for short term.
Error logs: Reading cr50 TPM mode I2C receive timeout I2C read failed: bus 3 addr 0x50
BUG=b:154310066 TEST=Check H1 has no I2C error occurring and can be updated by gsctool.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I85a63c1ab9a51d254873377a36d56823af11f0a9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40644 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index e0b3d50..498266e 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -92,7 +92,7 @@ .speed = I2C_SPEED_FAST, }, .i2c[3] = { - .speed = I2C_SPEED_FAST, + .speed = I2C_SPEED_STANDARD, .early_init = 1, }, .i2c[5] = {
-
EricR Lai (Code Review) -
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)