Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email )
Change subject: mb/google/geralt: Create variant Ciri
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78954/comment/b4dad5b2_9fbbaaa3 :
PS2, Line 9: and enable MAX98390 AMP for it.
Variants can differ. This one does not, so please be more specific.
Maybe it doesn't differ currently, but it looks like it will with all of the changes coming afterwards.
I don't think we need to worry about saying that it's a copy for the first commit. That's how almost every variant starts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78954?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25
Gerrit-Change-Number: 78954
Gerrit-PatchSet: 4
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 17:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-MessageType: comment