Attention is currently required from: Jakub Czapiga, Julius Werner. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59494 )
Change subject: libpayload/libc/fmap: Implement new FlashMap API ......................................................................
Patch Set 4:
(1 comment)
File payloads/libpayload/include/fmap.h:
https://review.coreboot.org/c/coreboot/+/59494/comment/866d1eb0_7d194703 PS4, Line 6: #include <commonlib/bsd/cb_err.h> Before using commonlib in exported headers, you'll also need to ensure that libpayload-using payloads can find it. We have multiple ways of using libpayload:
- a tree generated by "make install" needs to contain these files as a copy - lpgcc can work both in such a tree and from a source tree with build/ and needs to figure out the right locations
Food for thought: It _might_ be easier to make this more regular by copying commonlib headers into build/ somewhere (in a similar layout to what will be used in a "make install" tree) as an early build step and then just always use the same path.
It might be even easier to just copy all headers into build/ early so that the only difference between using build/ and using "make install" is the base directory.
-
Patrick Georgi (Code Review)