Change in coreboot[master]: google/trogdor: Add 'Lazor' derivative

[Julius Werner (Code Review)]

Hello Philip Chen, Bob Moragues,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/39784

to review the following change.

Change subject: google/trogdor: Add 'Lazor' derivative
......................................................................

google/trogdor: Add 'Lazor' derivative

This patch adds GOOGLE_LAZOR which is just a copy of GOOGLE_TROGDOR for
now.

Signed-off-by: Julius Werner 
Change-Id: I0dca8e1c29bdd91625d58b3cb583b530ed925e9f
---
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/trogdor/Kconfig.name
2 files changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/39784/1

diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig
index 27bd023..d1dbfe0 100644
--- a/src/mainboard/google/trogdor/Kconfig
+++ b/src/mainboard/google/trogdor/Kconfig
@@ -42,5 +42,6 @@
 config MAINBOARD_PART_NUMBER
    string
    default "Trogdor" if BOARD_GOOGLE_TROGDOR
+	default "Lazor" if BOARD_GOOGLE_LAZOR

endif # BOARD_GOOGLE_TROGDOR_COMMON
diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name
index 425c9bf..66636a6 100644
--- a/src/mainboard/google/trogdor/Kconfig.name
+++ b/src/mainboard/google/trogdor/Kconfig.name
@@ -2,3 +2,7 @@
 config BOARD_GOOGLE_TROGDOR
    bool "Trogdor"
    select BOARD_GOOGLE_TROGDOR_COMMON
+
+config BOARD_GOOGLE_LAZOR
+	bool "Lazor"
+	select BOARD_GOOGLE_TROGDOR_COMMON

[Bob Moragues (Code Review)]

Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39784 )

Change subject: google/trogdor: Add 'Lazor' derivative
......................................................................

Patch Set 1: Code-Review+1

LGTM

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39784 )

Change subject: google/trogdor: Add 'Lazor' derivative
......................................................................

Patch Set 1:

*ping*

Philip, wanna give a +2?

[Philip Chen (Code Review)]

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39784 )

Change subject: google/trogdor: Add 'Lazor' derivative
......................................................................

Patch Set 1: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39784 )

Change subject: google/trogdor: Add 'Lazor' derivative
......................................................................

google/trogdor: Add 'Lazor' derivative

This patch adds GOOGLE_LAZOR which is just a copy of GOOGLE_TROGDOR for
now.

Signed-off-by: Julius Werner 
Change-Id: I0dca8e1c29bdd91625d58b3cb583b530ed925e9f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39784
Tested-by: build bot (Jenkins) 
Reviewed-by: Bob Moragues 
Reviewed-by: Philip Chen 
---
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/trogdor/Kconfig.name
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philip Chen: Looks good to me, approved
  Bob Moragues: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig
index 27bd023..d1dbfe0 100644
--- a/src/mainboard/google/trogdor/Kconfig
+++ b/src/mainboard/google/trogdor/Kconfig
@@ -42,5 +42,6 @@
 config MAINBOARD_PART_NUMBER
    string
    default "Trogdor" if BOARD_GOOGLE_TROGDOR
+	default "Lazor" if BOARD_GOOGLE_LAZOR

endif # BOARD_GOOGLE_TROGDOR_COMMON
diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name
index 425c9bf..66636a6 100644
--- a/src/mainboard/google/trogdor/Kconfig.name
+++ b/src/mainboard/google/trogdor/Kconfig.name
@@ -2,3 +2,7 @@
 config BOARD_GOOGLE_TROGDOR
    bool "Trogdor"
    select BOARD_GOOGLE_TROGDOR_COMMON
+
+config BOARD_GOOGLE_LAZOR
+	bool "Lazor"
+	select BOARD_GOOGLE_TROGDOR_COMMON

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39784 )

Change subject: google/trogdor: Add 'Lazor' derivative
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1987
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1986
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1985

Please note: This test is under development and might not be accurate at all!

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39784 )

Change subject: google/trogdor: Add 'Lazor' derivative
......................................................................

Patch Set 2: Code-Review+1