Change in coreboot[master]: sb/intel/lynxpoint: Replace hard-coded IDs with defines - coreboot-gerrit

23 Nov 2020


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47808 )
Change subject: sb/intel/lynxpoint: Replace hard-coded IDs with defines
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47808/5/src/southbridge/intel/lynxp... 
File src/southbridge/intel/lynxpoint/azalia.c:
https://review.coreboot.org/c/coreboot/+/47808/5/src/southbridge/intel/lynxp... 
PS5, Line 136: /* 0x8c20 */
...
It might be useful to keep the IDs as comments, I don't know. I don't have a strong opinion on that. […]
So, if these numbers are meaningless, please don't put comments with them.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/47808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I910ab356dd8728c316018989bfb2689d4c67c2dc
Gerrit-Change-Number: 47808
Gerrit-PatchSet: 8
Gerrit-Owner:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Nov 2020 17:06:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To:  Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment