Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43974 )
Change subject: lib/libgcov.c: Do not redefine `alloca` ......................................................................
lib/libgcov.c: Do not redefine `alloca`
This is already defined in <commonlib/helpers.h> and it gets included implicitly by some other header. Fixes building with code coverage.
Change-Id: Id2dc6cc34b6f1d351d8e1b52d8cc4ada8666c673 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/lib/libgcov.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/43974/1
diff --git a/src/lib/libgcov.c b/src/lib/libgcov.c index 887351a..571aa7b 100644 --- a/src/lib/libgcov.c +++ b/src/lib/libgcov.c @@ -25,12 +25,12 @@ #ifdef __COREBOOT__ #include <stdlib.h> #include <string.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <assert.h> typedef s32 pid_t; #define gcc_assert(x) ASSERT(x) #define fprintf(file, x...) printk(BIOS_ERR, x) -#define alloca(size) __builtin_alloca(size) #include "gcov-glue.c"
/* Define MACROs to be used by coreboot compilation. */
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43974 )
Change subject: lib/libgcov.c: Do not redefine `alloca` ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43974 )
Change subject: lib/libgcov.c: Do not redefine `alloca` ......................................................................
lib/libgcov.c: Do not redefine `alloca`
This is already defined in <commonlib/helpers.h> and it gets included implicitly by some other header. Fixes building with code coverage.
Change-Id: Id2dc6cc34b6f1d351d8e1b52d8cc4ada8666c673 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43974 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/lib/libgcov.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/lib/libgcov.c b/src/lib/libgcov.c index 887351a..571aa7b 100644 --- a/src/lib/libgcov.c +++ b/src/lib/libgcov.c @@ -25,12 +25,12 @@ #ifdef __COREBOOT__ #include <stdlib.h> #include <string.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <assert.h> typedef s32 pid_t; #define gcc_assert(x) ASSERT(x) #define fprintf(file, x...) printk(BIOS_ERR, x) -#define alloca(size) __builtin_alloca(size) #include "gcov-glue.c"
/* Define MACROs to be used by coreboot compilation. */
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)