Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50265 )
Change subject: mb/intel/adlrvp: Enable Camera in ADL-M RVP ......................................................................
mb/intel/adlrvp: Enable Camera in ADL-M RVP
1. Configure Power Enable, Reset and Clock GPIO for both camera 2. Use same ASL code as ADL-P RVP
Configure RST, PWR_EN and IMGCLKOUT signals for WFC and UFC
TEST=Build, Boot and Verify streaming in both Camera
Signed-off-by: Varshit Pandya varshit.b.pandya@intel.com Change-Id: I70636eaa8d9bdf23d649e811b3ff4f33b1bc604e Reviewed-on: https://review.coreboot.org/c/coreboot/+/50265 Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com Reviewed-by: Rizwan Qureshi rizwan.qureshi@intel.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/adlrvp/gpio_m.c 1 file changed, 14 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Rizwan Qureshi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Ronak Kanabar: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/adlrvp/gpio_m.c b/src/mainboard/intel/adlrvp/gpio_m.c index 9eef27f..3790847 100644 --- a/src/mainboard/intel/adlrvp/gpio_m.c +++ b/src/mainboard/intel/adlrvp/gpio_m.c @@ -11,14 +11,14 @@ /* H6 : I2C1 SDA */ PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), /* B16 : I2C5 SDA */ - PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_B16, NONE, DEEP, NF2),
/* H5 : I2C0 SCL */ PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), /* H7 : I2C1 SCL */ PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1), /* B17 : I2C5 SCL */ - PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_B17, NONE, DEEP, NF2),
/* C5 : WWAN_PERST_N */ PAD_CFG_GPO(GPP_C5, 1, PLTRST), @@ -62,6 +62,18 @@ PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1),
+ /* CAM1_RST */ + PAD_CFG_GPO(GPP_R5, 1, PLTRST), + /* CAM2_RST */ + PAD_CFG_GPO(GPP_E15, 1, PLTRST), + /* CAM1_PWR_EN */ + PAD_CFG_GPO(GPP_B23, 1, PLTRST), + /* CAM2_PWR_EN */ + PAD_CFG_GPO(GPP_E16, 1, PLTRST), + /* IMGCLKOUT0 */ + PAD_CFG_NF(GPP_D4, NONE, DEEP, NF1), + /* IMGCLKOUT1 */ + PAD_CFG_NF(GPP_H20, NONE, DEEP, NF1), };
void variant_configure_gpio_pads(void)
-
Patrick Georgi (Code Review)